Fix subtree movement on MySQL. #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miracle2k
force-pushed
the
mysql-subtree
branch
from
c72720f to
bce08ee
Compare
The problem is that if a SET has multiple values in MySQL, column changes in the first clause affect the subsequent CASE statements. In other words, if we first change left_field and right_field, and then subsequently want to set tree_depth via a CASE(), the evaluation of that CASE will be affected by the left/right changes. As part of this change, I also fixed the ORM change detection for moves, which can now understand both the relationship and the id field changing.
miracle2k
force-pushed
the
mysql-subtree
branch
from
bce08ee to
e7e7bf5
Compare
Contributor
Author
|
I found another code path were the same bug occurred. This time around, the tests should also pass. I also improved the "ORM change detection"; it can now understand either the relationship or the id field changing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a though one and the fix requires a very recent version of SQLAlchemy, but checkout these links:
http://docs.sqlalchemy.org/en/latest/core/tutorial.html#updates-order-parameters
http://dev.mysql.com/doc/refman/5.7/en/update.html
The problem is that if a SET has multiple values in MySQL, column changes in the first clause affect the subsequent CASE statements.
In other words, if we first change
left_fieldandright_field, and then subsequently want to settree_depthvia a CASE(), the evaluation of that CASE will be affected by the left/right changes.