Refactor search page, migrate to /discover/ #4862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Prospector
commented
Dec 6, 2025
Prospector
commented
- Refactored search page to /discover/ which allows us to have some cleaner routes
- Put redirects in place
- Greatly improved TypeScript usage in search
IMB11
requested changes
Dec 9, 2025
Member
IMB11
left a comment
IMB11
left a comment
There was a problem hiding this comment.
Overall a good start - we should probably move the search page into the cross platform page system - since servers is going to be in the app we also need the full search page to be consistent between the two platforms? May be out of scope.
For now, migrating it to use tanstack + api-client would be a good help for me when im doing the content stuff later this week, also using the NormalPage component made earlier will be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.