-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Context API in callbacks #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KKonstantinov
wants to merge
9
commits into
modelcontextprotocol:main
Choose a base branch
from
KKonstantinov:feature/ctx-in-callbacks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Context API in callbacks #1241
KKonstantinov
wants to merge
9
commits into
modelcontextprotocol:main
from
KKonstantinov:feature/ctx-in-callbacks
+765
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
mattzcarey
reviewed
Dec 8, 2025
mattzcarey
reviewed
Dec 8, 2025
mattzcarey
reviewed
Dec 8, 2025
mattzcarey
reviewed
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR which aims to introduce convenience / quality of life improvements to the Typescript SDK.
It adds a
Contextutility (with the aim to be backwards-compatible, so anyone using RequestHandlerExtra will not have breaking changes), which exposes extra convenience methods and could be extended further down the line.Motivation and Context
It aims to explore the concept of a backwards-compatible
Contextutility class being passed in callbacks on the server-side. TheContextutility class provides convenience methods and can be further extended in the future. It provides access to methods like logging, sampling, elicitation (and others could be added) and one can call them from the callbacks without having access to theServerorMcpServerinstances.How Has This Been Tested?
Additional unit tests have been added.
Existing unit tests work with no changes.
Tests when callback is tied to RequestHandlerExtra.
Breaking Changes
No breaking changes.
The additions affect only server-side. Client-side should remain the same.
Types of changes
Checklist
Additional context
The changes follow existing concepts of the PythonSDK, applied in a similar fashion (to the extent that the libraries differ or similar in various parts of them) to Typescript.
Notes:
Context, but currently it needs to implementRequestHandlerExtrato keep backward compatibilityLogging Utility methods
Elicit from Context
Sampling from Context