environment variable support, regular expression, go-lint #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moepi
commented
Aug 1, 2018
| "regexp" | ||
|
|
||
| "github.com/mlabouardy/nexus-cli/registry" | ||
| "github.com/moepi/nexus-cli/registry" |
Author
There was a problem hiding this comment.
This needs to be reverted before merging.
moepi
force-pushed
the
feature/expressions
branch
from
5c1dee8 to
fa3c305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I could use the tool, but for my use it lacked support for regular expressions. On the way, I've added environment variable support, to get rid of filesystem as dependency and refactored parts of the code according to go-lint.
Related Issue
#8