Skip to content

Conversation

@alonsobsd
Copy link

Description

This is a initial support for FreeBSD

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@deacon-mp deacon-mp requested a review from Copilot October 6, 2025 22:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds initial FreeBSD support by including 'freebsd' in the platform list when creating analytic ability executors.

  • Extend platform loop to include 'freebsd'
  • No tests added for the new platform behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ability_id = str(uuid.uuid4())
executors = []
for pl in ['windows', 'darwin', 'linux']:
for pl in ['windows', 'darwin', 'linux', 'freebsd']:
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hardcoding the platform list makes future updates error-prone. Consider extracting the supported platforms to a shared constant (e.g., SUPPORTED_PLATFORMS) or config so the list is defined in one place and reused here.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant