Skip to content

Conversation

@brent-spyder
Copy link

Reason For Changes

When using the ToExcel exporter I noticed error messages coming from the typeChecker() function when I used the average score aggregation function. This is because the Techniques' scores come out as a float type. int is checked first, an error message is emitted, then float is checked.

Summary of Changes

I updated typeChecker() function to support a list of types, and I updated the score() method in technique.py to utilize the change.

Testing

I re-ran my code to export a layer to excel. The code worked as expected and I no longer received the error messages. I also ran the unit tests locally an everything continued to pass

@sonarqubecloud
Copy link

@brent-spyder brent-spyder changed the title Update/reduce type checker noise Update to reduce type checker noise Jan 14, 2025
@jondricek jondricek changed the base branch from master to main August 26, 2025 17:00
@elucchesileon elucchesileon self-assigned this Dec 3, 2025
@elucchesileon
Copy link
Contributor

Apologies for the late reply, but I'm looking into this.

Do you happen to have any sample code available?

I'm hesitant to accept the change as provided, since it alters the behavior. The current version of score() would cast a float to an int, but the proposed change does not.

@elucchesileon
Copy link
Contributor

I'm going to close this PR in favor of #216
That accomplishes the goal of eliminating the false error message, while otherwise preserving the original behavior.
Please watch that other PR for updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants