Cohttp-lwt: Send 100-continue on POST with Expect: 100-continue #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See RFC7231 section 5.1.1 on Expect 'Requirements for servers'. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Collaborator
|
Thanks a lot! |
Collaborator
|
Would it be possible to add it also to async? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RFC7231 section 5.1.1 on Expect 'Requirements for servers'.
I've tested this with Ezcurl-0.2.2 and a POST request which sends a 100-continue header.
Without this Curl will pause for 1s waiting for the server to send 100-continue. I also tested that inserting an artifical 10s sleep doesn't confuse curl (it gives up after 1s and sends the body anyway).
See Curl documentation on 100-continue and HTTP/1.1 RFC7231 5.1.1 Expect.
I've only implemented this for the Lwt backend for now.