Undo deprecation of connection value #1114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In mirage#798 the connection value has been deprecated with the claim it is useless. However, in fact it is used at least with the Mirage backend in order to track the connections for logging etc. (See last two comments of the PR.) In over 3 years no replacement has been added, so this change removes the deprecation until some alternative exists. (Which could be possibly Mirage only.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #798 the connection value has been deprecated with the claim it is useless. However, in fact it is used at least with the Mirage backend in order to track the connections for logging etc. (See last two comments of the PR.) In over 3 years no replacement has been added, so this change removes the deprecation until some alternative exists. (Which could be possibly Mirage only.)