Skip to content

Conversation

@dkdrk
Copy link

@dkdrk dkdrk commented Oct 10, 2017

No description provided.

@rlivsey
Copy link
Member

rlivsey commented Oct 10, 2017

👍 I like the direction this is going.

Would be great if it didn't use the Ember global, this is going away in future ember releases and don't think we should hang data off it.

Maybe should just be a global constant like APP_SVGS, or wrap it in define so that it can be imported into the app vs a global?

Eg similar pattern to shims like:

(function() {
  function svgModule() {
    'use strict';
    const SVGS = {} // the SVG data
    return { 'default': SVGS };
  }
  define('svgs', [], svgModule);
})();

@buschtoens
Copy link
Collaborator

Referencing buschtoens/broccoli-flatiron#1

@dkdrk dkdrk force-pushed the patch_decouple_from_appjs branch from 4320399 to dd64bba Compare October 10, 2017 12:00
@dkdrk dkdrk force-pushed the patch_decouple_from_appjs branch from db81d2e to ae513e7 Compare November 23, 2017 05:46
@dkdrk
Copy link
Author

dkdrk commented Nov 23, 2017

any other changes to be done @rlivsey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants