Release 0.1.0 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the Maven badge in README.md to reference microsphere-redis instead of microsphere-gateway for accuracy.
Introduced junit.version property and added JUnit BOM to dependencyManagement for consistent JUnit version management across modules.
Updated the hashCode test in ParameterMetadataTest to use assertNotEquals instead of assertFalse for improved clarity and correctness.
Updated ParameterTest to use assertNotEquals instead of assertFalse for hashCode comparisons, improving clarity and intent of the assertions.
Moved closing brace to a new line in the @SpringBootTest 'classes' array for improved readability and consistency.
Deleted the trailing newline at the end of DoubleSerializer.java to conform to file formatting standards.
Replaced fully qualified class names with simple class names in Javadoc references for improved readability in RangeModel.
Deleted an unnecessary blank line at the end of the pom.xml file to maintain consistent formatting.
Added explicit parameterNames fields to all method entries in spring-data-redis-metadata.yaml for improved clarity and introspection of Redis command interfaces.
Introduced a new field 'parameterNames' with corresponding getter and setter in MethodMetadata. Updated equals, toString, and related logic to include parameterNames for more detailed method metadata representation.
Updated the toString method in Parameter to use symbol constants for comma and square brackets from SymbolConstants, improving consistency and maintainability.
Updated ParameterMetadata.toString() to use COMMA, LEFT_SQUARE_BRACKET, and RIGHT_SQUARE_BRACKET from SymbolConstants for improved consistency and maintainability.
Extended MethodMetadataTest to include assertions and setup for the parameterNames property, improving test coverage for MethodMetadata's equality and getter/setter methods.
Introduces collection and storage of method parameter names in the generated metadata for Spring Data Redis command methods. Refactors parameter type resolution and updates the metadata map to include both parameter names and types.
Updated getParameterMetadataList to use parameter names from MethodMetadata when available, falling back to buildParameterMetadataList if not. Removed unused Parameter import and related code for improved clarity.
Introduced a unit test to verify that getParameterMetadataList returns the expected parameter metadata for Redis command methods, matching the output of buildParameterMetadataList.
Updated the test to use the parameter name from metadata if the reflection-based name is not present. This ensures compatibility with environments where parameter names are not retained at runtime.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Changed the project name from 'Microsphere Spring' to 'Microsphere Redis' in the license section to accurately reflect the repository.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the metadata handling for Redis command methods by adding support for parameter names in addition to parameter types. It updates the
MethodMetadataclass, the metadata generator, and related test cases to include and validate method parameter names. There are also minor improvements to string formatting and test assertions for clarity and consistency.Enhancements to Method Metadata:
parameterNamesfield to theMethodMetadataclass, with corresponding getter, setter, and inclusion inequals,hashCode, andtoStringmethods. [1] [2] [3]MethodMetadataTestto set and assertparameterNames, ensuring correct behavior and equality checks. [1] [2] [3]Metadata Generation Improvements:
SpringDataRedisMetadataGenerationDocletto extract and store method parameter names alongside parameter types when generating metadata, including a new metadata key and logic for resolving parameter names and types. [1] [2] [3]Code Quality and Consistency:
toStringmethods inParameterandParameterMetadatato use symbolic constants for formatting, ensuring consistency across metadata classes. [1] [2] [3] [4]ParameterTestandParameterMetadataTestto useassertNotEqualsfor clarity. [1] [2] [3]Dependency Management:
junit.versionin the parent POM for centralized test dependency management.Documentation:
README.mdto reference the correct artifact.