Skip to content

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 19, 2025

Brings in further improvements to handling of write backpressure. After this we no longer throttle at all which means that for older versions of bash at least on macOS interleaving is possible, but pasting and sending should be near instantaneous for any reasonable amount of text. I measured zsh injesting 5mb of data in ~14 seconds.

See:

Part of #246204, #283056

cc @anthonykim1

Brings in further improvements to handling of write backpressure. After
this we no longer throttle at all which means that for older versions of
bash at least on macOS interleaving is possible, but pasting and sending
should be near instantaneous for any reasonable amount of text. I
measured zsh injesting 5mb of data in ~14 seconds.

See:

- microsoft/node-pty#835
- microsoft/node-pty#837
- microsoft/node-pty#839

Part of #246204, #283056
@Tyriar Tyriar added this to the December / January 2026 milestone Dec 19, 2025
@Tyriar Tyriar self-assigned this Dec 19, 2025
Copilot AI review requested due to automatic review settings December 19, 2025 16:18
@Tyriar Tyriar enabled auto-merge December 19, 2025 16:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the node-pty dependency from version 1.1.0-beta42 to 1.1.0-beta43 to bring in improvements to write backpressure handling in the terminal. The update removes throttling to enable near-instantaneous pasting and sending for reasonable amounts of text, though this may allow interleaving with older bash versions on macOS.

Key changes:

  • Updates node-pty dependency version in both root and remote packages
  • Updates corresponding lockfiles with new version, resolved URL, and integrity hash

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updates node-pty version to ^1.1.0-beta43 in root package
package-lock.json Updates lockfile entry for node-pty with new version and integrity hash in root package
remote/package.json Updates node-pty version to ^1.1.0-beta43 in remote package
remote/package-lock.json Updates lockfile entry for node-pty with new version and integrity hash in remote package
Files not reviewed (1)
  • remote/package-lock.json: Language not supported

@Tyriar Tyriar merged commit 5e032c5 into main Dec 19, 2025
34 checks passed
@Tyriar Tyriar deleted the tyriar/node-pty-43 branch December 19, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants