Skip to content

70853n/272840 add hover colors #278809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
70853n wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −2
Open

70853n/272840 add hover colors #278809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
991a75a
feat: add hover background and foreground colors for titlebar (#272840)
Oct 24, 2025
b03a661
feat: add hover colors to titlebar buttons (#272840)
Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build/lib/stylelint/vscode-known-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,8 @@
"--vscode-textSeparator-foreground",
"--vscode-titleBar-activeBackground",
"--vscode-titleBar-activeForeground",
"--vscode-titleBar-activeHoverBackground",
"--vscode-titleBar-activeHoverForeground",
"--vscode-titleBar-border",
"--vscode-titleBar-inactiveBackground",
"--vscode-titleBar-inactiveForeground",
Expand Down
11 changes: 9 additions & 2 deletions src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,20 @@
color: var(--vscode-titleBar-activeForeground);
}

.monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item > .action-label:hover,
.monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item.monaco-dropdown-with-primary .action-label:hover {
background-color: var(--vscode-titleBar-activeHoverBackground);
color: var(--vscode-titleBar-activeHoverForeground);
}

.monaco-workbench .part.titlebar.inactive > .titlebar-container > .titlebar-center > .window-title > .command-center > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item > .action-label,
.monaco-workbench .part.titlebar.inactive > .titlebar-container > .titlebar-center > .window-title > .command-center > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item.monaco-dropdown-with-primary .action-label {
color: var(--vscode-titleBar-inactiveForeground);
}

.monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item > .action-label {
color: inherit;
.monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center > .monaco-toolbar > .monaco-action-bar > .actions-container > .action-item > .action-label:hover {
background-color: var(--vscode-titleBar-activeHoverBackground);
color: var(--vscode-titleBar-activeHoverForeground);
}

.monaco-workbench .part.titlebar > .titlebar-container > .titlebar-center > .window-title > .command-center .action-item.command-center-center {
Expand Down
4 changes: 4 additions & 0 deletions src/vs/workbench/common/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,10 @@ export const TITLE_BAR_BORDER = registerColor('titleBar.border', {
hcLight: contrastBorder
}, localize('titleBarBorder', "Title bar border color."));

export const TITLE_BAR_ACTIVE_HOVER_BACKGROUND = registerColor('titleBar.activeHoverBackground', toolbarHoverBackground, localize('titleBarActiveHoverBackground', "Title bar background when hovering over title bar actions with the mouse. Title bar actions include the back and forward navigation buttons as well as the command center."));

export const TITLE_BAR_ACTIVE_HOVER_FOREGROUND = registerColor('titleBar.activeHoverForeground', TITLE_BAR_ACTIVE_FOREGROUND, localize('titleBarActiveHoverForeground', "Title bar foreground when hovering over title bar actions with the mouse. Title bar actions include the back and forward navigation buttons as well as the command center."));

// < --- Menubar --- >

export const MENUBAR_SELECTION_FOREGROUND = registerColor('menubar.selectionForeground', TITLE_BAR_ACTIVE_FOREGROUND, localize('menubarSelectionForeground', "Foreground color of the selected menu item in the menubar."));
Expand Down
4 changes: 4 additions & 0 deletions src/vs/workbench/services/themes/common/workbenchThemeService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ export const COLOR_THEME_DARK_INITIAL_COLORS = {
'textSeparator.foreground': '#21262D',
'titleBar.activeBackground': '#181818',
'titleBar.activeForeground': '#CCCCCC',
'titleBar.activeHoverBackground': '#1F1F1F',
'titleBar.activeHoverForeground': '#FFFFFF',
'titleBar.border': '#2B2B2B',
'titleBar.inactiveBackground': '#1F1F1F',
'titleBar.inactiveForeground': '#9D9D9D',
Expand Down Expand Up @@ -338,6 +340,8 @@ export const COLOR_THEME_LIGHT_INITIAL_COLORS = {
'textSeparator.foreground': '#21262D',
'titleBar.activeBackground': '#F8F8F8',
'titleBar.activeForeground': '#1E1E1E',
'titleBar.activeHoverBackground': '#b8b8b850',
'titleBar.activeHoverForeground': '#1E1E1E',
'titleBar.border': '#E5E5E5',
'titleBar.inactiveBackground': '#F8F8F8',
'titleBar.inactiveForeground': '#8B949E',
Expand Down