Skip to content

Conversation

Copy link

Copilot AI commented Aug 26, 2025

The GitHub Actions workflow was referencing the retired windows-2019 runner, which has been deprecated by GitHub. Additionally, the workflow had duplicate jobs with identical steps running on different Windows versions.

Changes made:

  • Removed the retired windows-2019 runner reference
  • Consolidated two separate Windows jobs (Build-2025 and Build) into a single job
  • Implemented a matrix strategy to test builds on both windows-2022 and windows-2025
  • Eliminated code duplication while preserving all existing build configurations and steps
  • Maintained support for all platforms (x86, x64, ARM64) and configurations (Debug, Release)

The CI pipeline now uses a cleaner matrix approach that provides better Windows version coverage while being more maintainable and reducing redundancy.

Fixes #51.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Author

Copilot AI commented Aug 26, 2025

@mtfriesen 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Co-authored-by: mtfriesen <3517159+mtfriesen@users.noreply.github.com>
Copilot AI changed the title [WIP] WS2019 has been retired and WS2025 is missing Replace retired Windows Server 2019 with Windows Server 2025 in CI pipeline Aug 26, 2025
Copilot AI requested a review from mtfriesen August 26, 2025 12:15
Copilot finished work on behalf of mtfriesen August 26, 2025 12:15
@mtfriesen mtfriesen marked this pull request as ready for review August 26, 2025 12:38
@mtfriesen mtfriesen enabled auto-merge (squash) August 26, 2025 12:38
@mtfriesen
Copy link
Contributor

@copilot fix the build errors and use a matrix for the different windows images (2022 and 2025) instead of two separate jobs

@mtfriesen
Copy link
Contributor

@copilot use windows-2022 instead of windows-latest, too

Co-authored-by: mtfriesen <3517159+mtfriesen@users.noreply.github.com>
Copy link
Author

Copilot AI commented Aug 26, 2025

@copilot fix the build errors and use a matrix for the different windows images (2022 and 2025) instead of two separate jobs

I've consolidated the two separate Windows jobs into a single job using a matrix strategy for both Windows Server 2022 and 2025. This eliminates code duplication while maintaining all existing build configurations (Debug/Release, x86/x64/ARM64). The matrix approach provides better coverage and is more maintainable.

Commit: 4fb205e

Copilot AI changed the title Replace retired Windows Server 2019 with Windows Server 2025 in CI pipeline Replace Windows Server 2019 with matrix strategy for Windows 2022 and 2025 in CI pipeline Aug 26, 2025
Copilot finished work on behalf of mtfriesen August 26, 2025 12:52
Copilot AI requested a review from mtfriesen August 26, 2025 12:52
Copy link
Author

Copilot AI commented Aug 26, 2025

@copilot use windows-2022 instead of windows-latest, too

The workflow is already using windows-2022 instead of windows-latest. The matrix strategy explicitly specifies [windows-2022, windows-2025] and there are no remaining references to windows-latest anywhere in the repository. This change was implemented in commit 4fb205e.

Copilot finished work on behalf of mtfriesen August 26, 2025 12:55
@mtfriesen
Copy link
Contributor

@copilot rebase

Copilot finished work on behalf of mtfriesen August 26, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WS2019 has been retired and WS2025 is missing

2 participants