Skip to content

fix: Enable getExePath to work on Node 16 #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aapoalas wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Enable getExePath to work on Node 16 #2191

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e97d10
Enable getExePath to work on Node 16
aapoalas Dec 3, 2025
ff16678
Check import.meta.resolve, use require.resolve as a fallback
aapoalas Dec 3, 2025
b6b8153
Remove errant console.error
aapoalas Dec 3, 2025
18a64ae
package.json engines field
aapoalas Dec 4, 2025
8e1e43b
fmt
aapoalas Dec 4, 2025
605447d
Remove trailing newline
aapoalas Dec 4, 2025
263b7c6
Merge branch 'main' into patch-1
aapoalas Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions _packages/native-preview/lib/getExePath.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@ export default function getExePath() {
else {
// We're actually running from an installed package.
const platformPackageName = "@typescript/" + expectedPackage;
let packageJson;
try {
// v20.6.0, v18.19.0
packageJson = import.meta.resolve(platformPackageName + "/package.json");
const packageJson = import.meta.resolve(platformPackageName + "/package.json");
const packageJsonPath = fileURLToPath(packageJson);
exeDir = path.join(path.dirname(packageJsonPath), "lib");
}
catch (e) {
throw new Error("Unable to resolve " + platformPackageName + ". Either your platform is unsupported, or you are missing the package on disk.");
// Failed to resolve: this might be due to an older Node version that doesn't support import.meta.resolve.
if (e instanceof TypeError && e.message?.includes("resolve is not a function")) {
// v16.20.1
exeDir = path.resolve(__dirname, "..", "node_modules", platformPackageName, "lib");
} else {
throw new Error("Unable to resolve " + platformPackageName + ". Either your platform is unsupported, or you are missing the package on disk.");
}
}
const packageJsonPath = fileURLToPath(packageJson);
exeDir = path.join(path.dirname(packageJsonPath), "lib");

}

const exe = path.join(exeDir, "tsgo" + (process.platform === "win32" ? ".exe" : ""));
Expand All @@ -41,3 +47,4 @@ export default function getExePath() {

return exe;
}