Reroute cloud through IPC channel #10285
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| protected handleResponse(response: pxt.editor.CloudProxyResponse) { | ||
| if (this.pendingMessages[response.id]) { | ||
| this.pendingMessages[response.id](response); |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 7 months ago
To address the issue, we need to validate the response.id field before using it to access this.pendingMessages. Specifically:
- Check if
response.idexists as a key inthis.pendingMessagesusingObject.prototype.hasOwnProperty.call. - Ensure that the value associated with
response.idinthis.pendingMessagesis a function before invoking it.
This fix ensures that only valid and expected keys are used for dynamic method calls, mitigating the risk of runtime exceptions or unexpected behavior.
Suggested changeset
1
webapp/src/minecraftAuthClient.ts
| @@ -352,3 +352,4 @@ | ||
| protected handleResponse(response: pxt.editor.CloudProxyResponse) { | ||
| if (this.pendingMessages[response.id]) { | ||
| if (Object.prototype.hasOwnProperty.call(this.pendingMessages, response.id) && | ||
| typeof this.pendingMessages[response.id] === 'function') { | ||
| this.pendingMessages[response.id](response); |
Copilot is powered by AI and may make mistakes. Always verify output.
eanders-ms
reviewed
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to review this just yet; mostly just opening this for visibility. adds an alternate auth client that proxies cloud requests to the parent frame. in the future, i'll swap out the frame implementation with one that talks over the IPC channel to minecraft