Skip to content

Ensure 755 permissions on prebuild spawn-helper #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyriar merged 1 commit into from
Jan 3, 2026
Merged

Ensure 755 permissions on prebuild spawn-helper #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/prebuild.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,12 @@ if (!fs.existsSync(PREBUILD_DIR)) {
process.exit(1);
}

// Ensure spawn-helper has execute permission (may be stripped by npm pack)
Copy link
Contributor

@devm33 devm33 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by this. Seems to only happen on darwin-x64 and wasn't happening previously. Is npm pack definitely at fault?

Copy link
Member Author

@Tyriar Tyriar Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opus might have been lying about it due to leading. We should remove this anyway and go with the pipeline approach in https://github.com/microsoft/node-pty/pull/866/changes

Copy link
Contributor

@devm33 devm33 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok added reverting this to #866

if (process.platform === 'darwin') {
const spawnHelper = path.join(PREBUILD_DIR, 'spawn-helper');
if (fs.existsSync(spawnHelper)) {
fs.chmodSync(spawnHelper, 0o755);
}
}

process.exit(0);