Skip to content

Conversation

@wptestyyh
Copy link
Member

@wptestyyh wptestyyh commented Oct 14, 2025

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

Implement gRPC api to enable or disable access point after specified seconds

Technical Details

  • Add WifiAccessPointTimedEnable and WifiAccessPointTimedDisable
  • Implement NetRemoteService::WifiAccessPointTimedEnable and NetRemoteService::WifiAccessPointTimedDisable
  • Implement unit test WifiAccessPointTimedEnable API and WifiAccessPointTimedDisable API

Test Results

  • WifiAccessPointTimedDisable test passed
    ./netremote-test-unit "WifiAccessPointTimedDisable API"
    ===============================================================================
    All tests passed (31 assertions in 1 test case)
  • WifiAccessPointTimedEnable test passed
    ===============================================================================
    All tests passed (31 assertions in 1 test case)

Reviewer Focus

None

Future Work

Publish 0.5.3 release

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@wptestyyh wptestyyh requested a review from a team as a code owner October 14, 2025 18:19
@wptestyyh wptestyyh requested a review from a team October 16, 2025 17:27
@wptestyyh
Copy link
Member Author

The linux build is broken because of out of diskspace that is not the issue of the code change.
The windows build is https://mirror.msys2.org/msys/x86_64/msys2-runtime-3.4.10-4-x86_64.pkg.tar.zst has been deleted. I am trying to upgrade vcpkg submodule to fix it. No fix ETA yet

@wptestyyh wptestyyh merged commit 469e93a into develop Oct 20, 2025
1 of 4 checks passed
@wptestyyh wptestyyh deleted the timedenable branch October 20, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants