Skip to content

Conversation

@pixel-perfectionist
Copy link
Member

image

@pixel-perfectionist pixel-perfectionist requested a review from a team as a code owner December 4, 2025 17:46
@pixel-perfectionist pixel-perfectionist force-pushed the olkatruk/cap-theme/drawer branch 2 times, most recently from a314de8 to 3417b90 Compare December 4, 2025 17:47
@sxsx1xsxs
Copy link
Contributor

I pulled the PR and re-build, and have the storybook up but the drawers doesn't seem to have the updated border-radius?
Screenshot 2025-12-04 at 10 51 23 AM

Also, for drawer component, it's simple enough that I think we should add something into the table view as well

And there is some conflict in CAPtheme.tsx and plz resolve those

@pixel-perfectionist
Copy link
Member Author

I pulled the PR and re-build, and have the storybook up but the drawers doesn't seem to have the updated border-radius? Screenshot 2025-12-04 at 10 51 23 AM

Also, for drawer component, it's simple enough that I think we should add something into the table view as well

And there is some conflict in CAPtheme.tsx and plz resolve those

Did you switch a theme?
image

@sxsx1xsxs
Copy link
Contributor

I pulled the PR and re-build, and have the storybook up but the drawers doesn't seem to have the updated border-radius? Screenshot 2025-12-04 at 10 51 23 AM
Also, for drawer component, it's simple enough that I think we should add something into the table view as well
And there is some conflict in CAPtheme.tsx and plz resolve those

Did you switch a theme? image

yes, I did switch theme!

Copy link
Contributor

@sxsx1xsxs sxsx1xsxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm! sorry, I just tried again, I didn't switch the theme, that's why. Adding my reply/comment here so you also get the review status update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants