Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

Description

Corrects 5 issues in SdnDiag.Server.psm1 where property assignments referenced non-existent class members or contained typos:

  • Spelling fix: vfpctrl_list_unifiied_flowvfpctrl_list_unified_flow (line 408)
  • Property assignment corrections: Aligned property assignments with class definitions
    • SendBufferAllocationCount now correctly assigned (was SendBufferAllocationSize) for 'Send Buffer Allocation Count' metric (line 2421)
    • InsufficientRndisOperations (was InsufficientRndisOperationsBuffers) per class at line 234 (line 2430)
    • QuotaExceeded (was QuotaExceededErrors) per class at line 235 (line 2431)
    • $object.OffloadState.LsoV2Supported (was $object.PortState.LsoV2Supported) per class at line 164 (line 2231)

These changes ensure VM NIC statistics and VFP port state are correctly populated when collected.

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.
Original prompt
Please apply the following diffs and create a pull request.
Once the PR is ready, give it a title based on the messages of the fixes being applied.

[{"message":"The filename 'vfpctrl_list_unifiied_flow' contains a spelling error. 'unifiied' should be 'unified'.","fixFiles":[{"filePath":"src/modules/SdnDiag.Server.psm1","diff":"diff --git a/src/modules/SdnDiag.Server.psm1 b/src/modules/SdnDiag.Server.psm1\n--- a/src/modules/SdnDiag.Server.psm1\n+++ b/src/modules/SdnDiag.Server.psm1\n@@ -405,7 +405,7 @@\n                     vfpctrl /list-nat-range /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_nat_range' -FileType txt -Force\n                     vfpctrl /list-rule /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_rule' -FileType txt -Force\n                     vfpctrl /list-mapping /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_mapping' -FileType txt -Force\n-                    vfpctrl /list-unified-flow /port $port.Name | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_unifiied_flow'  -FileType txt -Force\n+                    vfpctrl /list-unified-flow /port $port.Name | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_unified_flow'  -FileType txt -Force\n                     vfpctrl /get-port-flow-settings /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_get_port_flow_settings' -FileType txt -Force\n                     vfpctrl /get-port-flow-stats /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_get_port_flow_stats'  -FileType txt -Force\n                     vfpctrl /get-flow-stats /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_get_flow_stats' -FileType txt -Force\n"}]},{"message":"The property assignment is incorrect. 'Send Buffer Allocation Count' should be assigned to SendBufferAllocationCount, not SendBufferAllocationSize.","fixFiles":[{"filePath":"src/modules/SdnDiag.Server.psm1","diff":"diff --git a/src/modules/SdnDiag.Server.psm1 b/src/modules/SdnDiag.Server.psm1\n--- a/src/modules/SdnDiag.Server.psm1\n+++ b/src/modules/SdnDiag.Server.psm1\n@@ -2418,7 +2418,7 @@\n                         'Packets Sent' { $object.VmNicStatistics.PacketsSent = $value }\n                         'Packets Received' { $object.VmNicStatistics.PacketsReceived = $value }\n                         'Interrupts Received' { $object.VmNicStatistics.InterruptsReceived = $value }\n-                        'Send Buffer Allocation Count' { $object.VmNicStatistics.SendBufferAllocationSize = $value }\n+                        'Send Buffer Allocation Count' { $object.VmNicStatistics.SendBufferAllocationCount = $value }\n                         'Send Buffer Allocation Size' { $object.VmNicStatistics.SendBufferAllocationSize = $value }\n                         'Receive Buffer Allocation Count' { $object.VmNicStatistics.ReceiveBufferAllocationCount = $value }\n                         'Receive Buffer Allocation Size' { $object.VmNicStatistics.ReceiveBufferAllocationSize = $value }\n"}]},{"message":"The property name is incorrect. Based on the class definition at line 234, it should be InsufficientRndisOperations, not InsufficientRndisOperationsBuffers.","fixFiles":[{"filePath":"src/modules/SdnDiag.Server.psm1","diff":"diff --git a/src/modules/SdnDiag.Server.psm1 b/src/modules/SdnDiag.Server.psm1\n--- a/src/modules/SdnDiag.Server.psm1\n+++ b/src/modules/SdnDiag.Server.psm1\n@@ -2427,7 +2427,7 @@\n                         'Pending Routed Packets' { $object.VmNicStatistics.PendingRoutedPackets = $value }\n                         'Insufficient Receive Buffers' { $object.VmNicStatistics.InsufficientReceiveBuffers = $value }\n                         'Insufficient Send Buffers' { $object.VmNicStatistics.InsufficientSendBuffers = $value }\n-                        'Insufficient RNDIS Operations Buffers' { $object.VmNicStatistics.InsufficientRndisOperationsBuffers = $value }\n+                        'Insufficient RNDIS Operations Buffers' { $object.VmNicStatistics.InsufficientRndisOperations = $value }\n                         'Quota Exceeded Errors' { $object.VmNicStatistics.QuotaExceededErrors = $value }\n                         'Vsp Paused' { $object.VmNicStatistics.VspPaused = $value }\n \n"}]},{"message":"The property name is incorrect. Based on the class definition at line 235, it should be QuotaExceeded, not QuotaExceededErrors.","fixFiles":[{"filePath":"src/modules/SdnDiag.Server.psm1","diff":"diff --git a/src/modules/SdnDiag.Server.psm1 b/src/modules/SdnDiag.Server.psm1\n--- a/src/modules/SdnDiag.Server.psm1\n+++ b/src/modules/SdnDiag.Server.psm1\n@@ -2428,7 +2428,7 @@\n    ...

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ver.psm1

Co-authored-by: arudell <18577812+arudell@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix spelling error in filename 'vfpctrl_list_unified_flow' Fix spelling errors and incorrect property assignments in SdnDiag.Server.psm1 Dec 31, 2025
Copilot AI requested a review from arudell December 31, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants