Add 'Points' as a unit of measure in Screen Ruler #44048
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Copilot finished reviewing on behalf of
ThanhNguyxn
December 3, 2025 08:19
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds "Points" (pt) as a new measurement unit option in Screen Ruler. Points are a standard typography unit where 1 point = 1/72 inch, making this particularly useful for developers working with WPF/XAML, font sizes, and design specifications. The implementation correctly follows the existing pattern used for other measurement units and includes proper conversion logic for both physical DPI and 96 DPI fallback scenarios.
Key Changes
- Added Point enum value (16) following power-of-2 pattern for bitwise operations
- Implemented dual-path conversion logic (physical DPI and 96 DPI fallback)
- Added localized resource strings for UI and abbreviation ("pt")
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/MeasureTool/MeasureToolCore/Measurement.h | Added Point=16 to enum and expanded abbreviations array to 5 elements |
| src/modules/MeasureTool/MeasureToolCore/Measurement.cpp | Implemented Point conversion logic, added to GetUnitFromIndex, InitResources, GetUnitAbbreviation, Print function, and allUnits array |
| src/modules/MeasureTool/MeasureToolUI/Strings/en-us/Resources.resw | Added "pt" abbreviation resource string |
| src/settings-ui/Settings.UI/SettingsXAML/Views/MeasureToolPage.xaml | Added Points ComboBoxItem to measurement units dropdown |
| src/settings-ui/Settings.UI/Strings/en-us/Resources.resw | Added "Points" display name resource string |
ThanhNguyxn
force-pushed
the
fix/screen-ruler-points-unit
branch
3 times, most recently
from
220105e to
5a28b42
Compare
This adds 'Points' (pt) as a new measurement unit option in Screen Ruler. Points are commonly used in typography and design (1 point = 1/72 inch). - Add Point enum value (16) to Measurement::Unit - Add conversion logic for Points based on pixel-to-mm ratio - Add 'pt' abbreviation string resource - Add Points option to Settings UI ComboBox Fixes microsoft#39464
ThanhNguyxn
force-pushed
the
fix/screen-ruler-points-unit
branch
from
5a28b42 to
1abaf0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds "Points" (pt) as a new measurement unit option in Screen Ruler, addressing the feature request in #39464.
Points are a standard unit in typography and design, where 1 point = 1/72 inch. This is particularly useful for developers working with WPF/XAML measurements, font sizes, and design specifications.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Changes Made:
Measurement.h
Point = 16to theMeasurement::UnitenumMeasurement.cpp
pixels * px2mmRatio / 10.0f / 2.54f * 72.0fpixels / 96.0f * 72.0f(assumes 96 DPI)GetUnitFromIndex()(index 4)InitResources()GetUnitAbbreviation()allUnitsarray for Print functionMeasureToolUI Resources.resw
MeasurementUnitAbbrPointwith value "pt"MeasureToolPage.xaml
Settings.UI Resources.resw
MeasureTool_UnitsOfMeasure_Points.Contentwith value "Points"Validation:
The implementation follows the existing patterns for other measurement units (Pixels, Inches, Centimeters, Millimeters) and maintains consistency with the codebase.