Add inverted punctuation marks (¡¿) to Quick Accent for Spanish and Catalan #44039
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Copilot finished reviewing on behalf of
ThanhNguyxn
December 3, 2025 03:14
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Quick Accent feature for Spanish and Catalan languages by adding dedicated key mappings for inverted punctuation marks (¡ and ¿), which are essential characters in these languages. The implementation follows the technical constraint that Quick Accent detects virtual key codes rather than final characters, so the inverted marks are mapped to VK_1 (for ! typed with Shift+1) and VK_SLASH_ (for ? typed with Shift+/).
Key Changes:
- Added
VK_1 => new[] { "¡" }andVK_SLASH_ => new[] { "¿" }mappings to both Spanish and Catalan language configurations - Preserved existing
VK_COMMAbehavior for backward compatibility - Consistent implementation across both language definitions
ThanhNguyxn
force-pushed
the
fix/quick-accent-spanish-punctuation
branch
3 times, most recently
from
3eab642 to
682b3de
Compare
When using Spanish or Catalan language in Quick Accent: - Pressing '1' + activation key now shows '' (inverted exclamation mark) - Pressing '/' + activation key now shows '' (inverted question mark) This makes it easier to type Spanish/Catalan punctuation without needing to remember the VK_COMMA shortcut that shows all four marks. The existing VK_COMMA behavior (showing ?!) is preserved for users who prefer that method. Fixes microsoft#20618
ThanhNguyxn
force-pushed
the
fix/quick-accent-spanish-punctuation
branch
from
682b3de to
e84436e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds inverted punctuation marks (
¡and¿) to Quick Accent for Spanish and Catalan languages, making them accessible via dedicated key combinations.References and Relevant Issues
Fixes #20618
Detailed Description of the Pull Request / Additional comments
Feature Description
When using Spanish or Catalan language in Quick Accent:
1+ activation key (e.g., Space) now shows¡(inverted exclamation mark)/+ activation key now shows¿(inverted question mark)Technical Details
On US keyboard layout:
!is typed withShift + 1, which registers asVK_1?is typed withShift + /, which registers asVK_SLASH_Since Quick Accent detects virtual key codes rather than the final character, adding the inverted marks to these key mappings allows users to:
!(Shift+1)¡from the Quick Accent menuChanges Made
VK_1 => new[] { "¡" }andVK_SLASH_ => new[] { "¿" }to Spanish (SP) languageBackward Compatibility
The existing
VK_COMMAbehavior (showing¿?¡!) is preserved for users who prefer that method.Validation Steps Performed