Skip to content

Remove SkipModuleReload parameter #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FabienTschanz wants to merge 1 commit into
base: Dev
Choose a base branch
from
Open

Remove SkipModuleReload parameter #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Modules/MSCloudLoginAssistant/ConnectionProfile.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,9 +531,6 @@ class ExchangeOnline:Workload
[string]
$AzureADAuthorizationEndpointUri

[boolean]
$SkipModuleReload = $false

[System.String[]]
$CmdletsToLoad = @()

Expand Down Expand Up @@ -1057,9 +1054,6 @@ class PowerPlatformREST:Workload

class SecurityComplianceCenter:Workload
{
[boolean]
$SkipModuleReload = $false

[string]
$ConnectionUrl

Expand Down
7 changes: 0 additions & 7 deletions Modules/MSCloudLoginAssistant/MSCloudLoginAssistant.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ function Connect-M365Tenant
[System.String]
$CertificatePath,

[Parameter()]
[System.Boolean]
$SkipModuleReload = $false,

[Parameter()]
[Switch]
$Identity,
Expand Down Expand Up @@ -158,7 +154,6 @@ function Connect-M365Tenant
}
'ExchangeOnline'
{
$Script:MSCloudLoginConnectionProfile.ExchangeOnline.SkipModuleReload = $SkipModuleReload
$Script:MSCloudLoginConnectionProfile.ExchangeOnline.CmdletsToLoad = $ExchangeOnlineCmdlets
$Script:MSCloudLoginConnectionProfile.ExchangeOnline.Connect()
}
Expand Down Expand Up @@ -252,7 +247,6 @@ function Connect-M365Tenant
}
'SecurityComplianceCenter'
{
$Script:MSCloudLoginConnectionProfile.SecurityComplianceCenter.SkipModuleReload = $SkipModuleReload
$Script:MSCloudLoginConnectionProfile.SecurityComplianceCenter.Connect()
}
'SharePointOnlineREST'
Expand Down Expand Up @@ -482,7 +476,6 @@ function Compare-InputParametersForChange
$currentParameters.Add('UserName', $currentParameters['Credential'].UserName)
}
$currentParameters.Remove('Credential') | Out-Null
$currentParameters.Remove('SkipModuleReload') | Out-Null
$currentParameters.Remove('CmdletsToLoad') | Out-Null
$currentParameters.Remove('UseModernAuth') | Out-Null
$currentParameters.Remove('ProfileName') | Out-Null
Expand Down
4 changes: 1 addition & 3 deletions Modules/MSCloudLoginAssistant/Workloads/ExchangeOnline.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,8 @@ function Connect-MSCloudLoginExchangeOnline
}
}

if ($Script:MSCloudLoginConnectionProfile.ExchangeOnline.Connected -and `
$Script:MSCloudLoginConnectionProfile.ExchangeOnline.SkipModuleReload)
if ($Script:MSCloudLoginConnectionProfile.ExchangeOnline.Connected)
{
$Script:MSCloudLoginConnectionProfile.ExchangeOnline.Connected = $true
return
}

Expand Down
3 changes: 1 addition & 2 deletions Modules/MSCloudLoginAssistant/Workloads/SecurityCompliance.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ function Connect-MSCloudLoginSecurityCompliance
}

Add-MSCloudLoginAssistantEvent -Message "Connection Profile: $($Script:MSCloudLoginConnectionProfile.SecurityComplianceCenter | Out-String)" -Source $source
if ($Script:MSCloudLoginConnectionProfile.SecurityComplianceCenter.Connected -and `
$Script:MSCloudLoginConnectionProfile.SecurityComplianceCenter.SkipModuleReload)
if ($Script:MSCloudLoginConnectionProfile.SecurityComplianceCenter.Connected)
{
return
}
Expand Down