Handle out of bound access in D3DX12ParsePipelineStream #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbourn
requested changes
Nov 8, 2024
walbourn
reviewed
Feb 28, 2025
| return E_INVALIDARG; | ||
| } | ||
|
|
||
| static const UINT SizesOfSubobject[] = { |
Member
There was a problem hiding this comment.
As written, this will end up in the data segment of every .obj file which is a bit of duplication.
@jenatali Would you prefer we use something like extern const __declspec(selectany) UINT g_SizeOfSubobject[] here -or- create a .cpp file that hosts the one copy of it?
Member
There was a problem hiding this comment.
I don't like either of those approaches. I'm honestly not a huge fan of using a data table here that's separate from the switch. I don't see the point of it.
If ASAN says there's a bug let's just fix the bug, I assume it's a copy/paste bug, we don't need a paradigm shift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, was working on some project that uses DirectX-Headers, launched it with Asan and catched out of bound reads. This pull request fixes it