IAC version updates in core, devops, common templates #4799

tamirkamara · 2026-01-05T08:50:24Z

What is being addressed

Various IAC components are too old and should be updated:

Terraform and its providers
Azure CLI
Porter and its dependencies

.devcontainer/devcontainer.json

marrobi

LGTM

tamirkamara · 2026-01-05T12:16:27Z

/test-extended

github-actions · 2026-01-05T12:16:43Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/20715114450 (with refid b1defb47)

(in response to this comment from @tamirkamara)

github-actions · 2026-01-05T12:17:19Z

Unit Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit fe09dd8.

♻️ This comment has been updated with latest results.

tamirkamara · 2026-01-05T14:55:24Z

/test-extended

github-actions · 2026-01-05T14:55:36Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/20719239891 (with refid b1defb47)

(in response to this comment from @tamirkamara)

templates iad version updates

tamirkamara · 2026-01-05T15:19:38Z

/test-extended

github-actions · 2026-01-05T15:19:52Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/20719947187 (with refid b1defb47)

(in response to this comment from @tamirkamara)

tamirkamara · 2026-01-05T15:43:56Z

/test-destroy-env

github-actions · 2026-01-05T15:44:24Z

Destroying branch test environment (RG: rg-tre2bc8a82e)... (run: https://github.com/microsoft/AzureTRE/actions/runs/20720661518)

github-actions · 2026-01-05T15:44:28Z

Branch test environment destroy complete (RG: rg-tre2bc8a82e)

github-actions · 2026-01-05T15:44:33Z

Destroying PR test environment (RG: rg-treb1defb47)... (run: https://github.com/microsoft/AzureTRE/actions/runs/20720661518)

github-actions · 2026-01-05T15:49:31Z

Destroying PR test environment (RG: rg-treb1defb47)... (run: https://github.com/microsoft/AzureTRE/actions/runs/20720661518)

tamirkamara · 2026-01-06T18:03:29Z

/test-extended

github-actions · 2026-01-06T18:03:49Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/20757337607 (with refid b1defb47)

(in response to this comment from @tamirkamara)

tamirkamara · 2026-01-07T07:41:31Z

/test-destroy-env

github-actions · 2026-01-07T07:42:10Z

Destroying PR test environment (RG: rg-treb1defb47)... (run: https://github.com/microsoft/AzureTRE/actions/runs/20774236226)

github-actions · 2026-01-07T07:42:14Z

Destroying branch test environment (RG: rg-tre2bc8a82e)... (run: https://github.com/microsoft/AzureTRE/actions/runs/20774236226)

github-actions · 2026-01-07T07:42:19Z

Branch test environment destroy complete (RG: rg-tre2bc8a82e)

github-actions · 2026-01-07T08:10:03Z

PR test environment destroy complete (RG: rg-treb1defb47)

tamirkamara · 2026-01-07T08:12:03Z

/test

github-actions · 2026-01-07T08:12:17Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/20774888114 (with refid b1defb47)

(in response to this comment from @tamirkamara)

tamirkamara · 2026-01-07T09:12:14Z

/test-extended

github-actions · 2026-01-07T09:12:29Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/20776350980 (with refid b1defb47)

(in response to this comment from @tamirkamara)

tamirkamara · 2026-01-08T08:33:13Z

/test

github-actions · 2026-01-08T08:33:31Z

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/20810588788 (with refid b1defb47)

(in response to this comment from @tamirkamara)

tamirkamara · 2026-01-08T09:01:42Z

/test-force-approve
There was an extended run with almost all tests successful. The rest were tested locally.

github-actions · 2026-01-08T09:01:55Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a824e00)

(in response to this comment from @tamirkamara)

This reverts commit 655ad9c.

Copilot

Pull request overview

This PR updates infrastructure-as-code components across the Azure TRE solution, including Terraform (1.9.8 -> 1.14.3), Azure CLI (2.67.0 -> 2.81.0), Porter (v1.2.1 -> v1.4.0), and various Terraform providers. The updates also migrate from the deprecated hashicorp/template provider to the hashicorp/cloudinit provider and the built-in templatefile function.

Key changes include:

Terraform provider updates (azurerm 4.27.0 -> 4.57.0, azapi 2.3.0 -> 2.8.0, azuread 3.3.0 -> 3.7.0)
Breaking API changes adapted (property renames, diagnostic setting changes)
Docker version updates (27.4.1 -> 29.1.3, containerd 1.7.24 -> 2.2.1)
Migration from deprecated template provider to cloudinit provider
Azure CLI command syntax updates (-u -> --client-id)

Reviewed changes

Copilot reviewed 48 out of 58 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
templates/workspaces/base/terraform/providers.tf	Updated azurerm to 4.57.0 and azapi to 2.8.0
templates/workspaces/base/terraform/keyvault.tf	Renamed enable_rbac_authorization to rbac_authorization_enabled; updated diagnostic setting metric block
templates/workspaces/base/terraform/.terraform.lock.hcl	Updated provider lock hashes for new versions
templates/workspaces/base/porter.yaml	Bumped version to 2.8.1; updated Terraform to 1.14.3 and Azure CLI to 2.81.0
templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/terraform/main.tf	Updated azurerm and azuread provider versions
templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/porter.yaml	Updated VM SKU to win11-25h2-pro; made shutdown_time optional
templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/main.tf	Replaced template provider with cloudinit provider
templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/locals.tf	Moved template rendering to local values using templatefile function
templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/linuxvm.tf	Updated data source from template_cloudinit_config to cloudinit_config
templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/data.tf	Removed deprecated template_file data sources
templates/workspace_services/guacamole/terraform/web_app.tf	Added vnet_image_pull_enabled property; removed azapi workarounds
templates/workspace_services/guacamole/terraform/providers.tf	Updated providers and removed azapi dependency
templates/shared_services/sonatype-nexus-vm/terraform/vm.tf	Migrated from template provider to cloudinit provider
templates/shared_services/sonatype-nexus-vm/terraform/main.tf	Replaced template with cloudinit provider; updated azurerm to 4.57.0
templates/shared_services/firewall/terraform/providers.tf	Updated azurerm to 4.57.0
templates/shared_services/certs/terraform/main.tf	Updated azurerm to 4.57.0
resource_processor/vmss_porter/Dockerfile	Updated Azure CLI, Porter, and Docker versions
resource_processor/tests_rp/test_commands.py	Fixed test to use --client-id instead of -u flag
resource_processor/helpers/commands.py	Updated az login command syntax
resource_processor/_version.py	Bumped version to 0.13.1
devops/version.txt	Bumped version to 0.6.3
devops/terraform/terraform.tf	Updated azurerm to 4.57.0
devops/terraform/main.tf	Fixed enable_rbac_authorization to rbac_authorization_enabled
core/version.txt	Bumped version to 0.16.12
core/terraform/resource_processor/vmss_porter/main.tf	Replaced template with cloudinit provider
core/terraform/resource_processor/vmss_porter/locals.tf	Added cloudconfig_content using templatefile
core/terraform/resource_processor/vmss_porter/data.tf	Removed template_file; updated to cloudinit_config
core/terraform/resource_processor/vmss_porter/cloud-config.yaml	Updated package versions
core/terraform/main.tf	Updated providers and added cloudinit
core/terraform/keyvault.tf	Property and diagnostic setting updates
core/terraform/servicebus.tf	Updated metric to enabled_metric
core/terraform/network/network.tf	Added commented subnet delegation block
core/terraform/firewall/firewall.tf	Updated diagnostic setting metric block
core/terraform/dns-policy.tf	Updated diagnostic setting metric block
core/terraform/deploy.sh	Added --parallelism=25 flag
core/terraform/api-webapp.tf	Added vnet_image_pull_enabled; removed azapi workarounds
core/terraform/appgateway/appgateway.tf	Updated diagnostic setting metric block
core/terraform/airlock/eventgrid_topics.tf	Renamed source_arm_resource_id to source_resource_id; updated metric blocks
core/terraform/airlock/airlock_processor.tf	Updated diagnostic setting metric block
CHANGELOG.md	Added entry for infrastructure updates
.devcontainer/devcontainer.json	Updated debug configuration types
.devcontainer/Dockerfile	Updated Terraform, Porter, Docker, and Azure CLI versions

Files not reviewed (10)

core/terraform/.terraform.lock.hcl: Language not supported
devops/terraform/.terraform.lock.hcl: Language not supported
templates/shared_services/certs/terraform/.terraform.lock.hcl: Language not supported
templates/shared_services/firewall/terraform/.terraform.lock.hcl: Language not supported
templates/shared_services/sonatype-nexus-vm/terraform/.terraform.lock.hcl: Language not supported
templates/workspace_services/guacamole/terraform/.terraform.lock.hcl: Language not supported
templates/workspace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/terraform/.terraform.lock.hcl: Language not supported
templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/.terraform.lock.hcl: Language not supported
templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/terraform/.terraform.lock.hcl: Language not supported
templates/workspaces/base/terraform/.terraform.lock.hcl: Language not supported

templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/porter.yaml

core/terraform/network/network.tf

core/terraform/main.tf

templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/porter.yaml

templates/workspaces/base/porter.yaml

core/terraform/dns-policy.tf

core/terraform/deploy.sh

.devcontainer/Dockerfile

core/terraform/resource_processor/vmss_porter/cloud-config.yaml

templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/porter.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

tamirkamara · 2026-01-08T14:47:38Z

/test-force-approve

github-actions · 2026-01-08T14:47:55Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit fe09dd8)

(in response to this comment from @tamirkamara)

tamirkamara changed the title ~~IAC version updates in core/devopx~~ IAC version updates in core/devops Jan 5, 2026

tamirkamara commented Jan 5, 2026

View reviewed changes

.devcontainer/devcontainer.json Show resolved Hide resolved

tamirkamara marked this pull request as ready for review January 5, 2026 09:02

tamirkamara requested a review from a team as a code owner January 5, 2026 09:02

marrobi approved these changes Jan 5, 2026

View reviewed changes

Base automatically changed from tamirkamara/uncomment-test to main January 5, 2026 10:34

tamirkamara force-pushed the tamirkamara/core-iac-version-updates branch from de914d5 to 4cb04b5 Compare January 5, 2026 12:15

IAC version updates in core/devopx

a4d5254

tamirkamara force-pushed the tamirkamara/core-iac-version-updates branch from 4cb04b5 to a4d5254 Compare January 5, 2026 14:40

add tflint-ignore

4c5266e

tamirkamara changed the title ~~IAC version updates in core/devops~~ IAC version updates in core, devops, common templates Jan 5, 2026

Templates iac version updates (#4800)

19f905a

templates iad version updates

tamirkamara enabled auto-merge (squash) January 8, 2026 08:34

tamirkamara added 2 commits January 8, 2026 08:36

Increase Terraform parallelism in core

00b84f3

changelog

a824e00

martinpeck approved these changes Jan 8, 2026

View reviewed changes

tamirkamara added 2 commits January 8, 2026 09:55

update workflow

655ad9c

Revert "update workflow"

cb3ad13

This reverts commit 655ad9c.

Copilot AI review requested due to automatic review settings January 8, 2026 13:38

Merge branch 'main' into tamirkamara/core-iac-version-updates

c8010d2

Copilot started reviewing on behalf of tamirkamara January 8, 2026 13:38 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

tamirkamara and others added 3 commits January 8, 2026 16:27

Update core/terraform/deploy.sh

6272429

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update core/terraform/network/network.tf

9051ef7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

change comment

fe09dd8

tamirkamara merged commit 36a78d0 into main Jan 8, 2026
15 checks passed

tamirkamara deleted the tamirkamara/core-iac-version-updates branch January 8, 2026 14:47

IAC version updates in core, devops, common templates #4799

IAC version updates in core, devops, common templates #4799

Uh oh!

Conversation

tamirkamara commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is being addressed

Uh oh!

Uh oh!

marrobi left a comment

Choose a reason for hiding this comment

Uh oh!

tamirkamara commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

tamirkamara commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

tamirkamara commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

tamirkamara commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

tamirkamara commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

tamirkamara commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

tamirkamara commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

tamirkamara commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

tamirkamara commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

tamirkamara commented Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tamirkamara commented Jan 5, 2026 •

edited

Loading

github-actions bot commented Jan 5, 2026 •

edited

Loading