Exporter options for aspnetcore and workerservice #3066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2025
There was a problem hiding this comment.
Pull request overview
This PR adds four new exporter configuration properties to ApplicationInsightsServiceOptions for both AspNetCore and WorkerService SDKs, making them configurable via code and appsettings.json. These properties flow through to the Azure Monitor Exporter.
- Added
TracesPerSecond,DisableOfflineStorage,StorageDirectory, andEnableTraceBasedLogsSamplerproperties with appropriate defaults - Implemented property mapping from ApplicationInsightsServiceOptions to AzureMonitorExporterOptions with validation for TracesPerSecond
- Added comprehensive test coverage and updated documentation
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NETCORE/src/Shared/Extensions/ApplicationInsightsServiceOptions.cs | Defines the four new properties with XML documentation, defaults, and updates CopyPropertiesTo method |
| NETCORE/src/Microsoft.ApplicationInsights.WorkerService/ApplicationInsightsExtensions.cs | Maps new properties from service options to exporter options with TracesPerSecond validation |
| NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs | Maps new properties from service options to exporter options with TracesPerSecond validation (identical logic to WorkerService) |
| NETCORE/test/Shared/ConfigurationTests.cs | Adds tests for reading each property from configuration and validating property flow, plus a test for TracesPerSecond validation |
| NETCORE/test/Microsoft.ApplicationInsights.WorkerService.Tests/content/config-all-settings-true.json | Adds test values for the new properties with "true" settings |
| NETCORE/test/Microsoft.ApplicationInsights.WorkerService.Tests/content/config-all-settings-false.json | Adds test values for the new properties with "false" settings and StorageDirectory |
| NETCORE/test/Microsoft.ApplicationInsights.WorkerService.Tests/content/config-all-default.json | Adds default test values for the new properties |
| NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/content/config-all-settings-true.json | Adds test values for the new properties with "true" settings |
| NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/content/config-all-settings-false.json | Adds test values for the new properties with "false" settings and StorageDirectory |
| NETCORE/test/Microsoft.ApplicationInsights.AspNetCore.Tests/content/config-all-default.json | Adds default test values for the new properties |
| NETCORE/test/IntegrationTests.Tests/content/config-all-settings-true.json | Adds test values for the new properties with "true" settings |
| NETCORE/test/IntegrationTests.Tests/content/config-all-settings-false.json | Adds test values for the new properties with "false" settings and StorageDirectory |
| NETCORE/test/IntegrationTests.Tests/content/config-all-default.json | Adds default test values for the new properties |
| NETCORE/Readme.md | Documents the new configuration options with code examples and JSON configuration examples |
| .publicApi/Microsoft.ApplicationInsights.WorkerService.dll/Stable/PublicAPI.Unshipped.txt | Documents public API additions for the new properties |
| .publicApi/Microsoft.ApplicationInsights.AspNetCore.dll/Stable/PublicAPI.Unshipped.txt | Documents public API additions for the new properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NETCORE/test/Microsoft.ApplicationInsights.WorkerService.Tests/content/config-all-default.json
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Jan 1, 2026
Member
|
Check this before merge - #3066 (comment) |
Member
Skip fixing this one, we could remove later. |
Member
Author
|
/check-enforcer override |
Member
This command won't work for this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following properties to ApplicationInsightsServiceOptions & configurable via appinsights.json for AspNetCore & WorkerService:
SamplingRatio & EnableAdaptiveSampling will be modified in another PR.