-
Notifications
You must be signed in to change notification settings - Fork 293
Exporter options for base module #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds public APIs to the TelemetryConfiguration class to configure Azure Monitor exporter options for ApplicationInsights 3.x. These methods provide a user-friendly way to configure sampling, storage, live metrics, and trace-based log sampling settings.
- Adds six new public configuration methods to
TelemetryConfiguration - Provides comprehensive test coverage with 350 lines of unit tests
- Updates the public API surface documentation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| BASE/src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs | Adds six new public methods (SetSamplingRatio, SetTracesPerSecond, SetStorageDirectory, DisableOfflineStorage, DisableLiveMetrics, DisableTraceBasedLogsSampling) to configure AzureMonitorExporterOptions |
| BASE/Test/Microsoft.ApplicationInsights.Test/Microsoft.ApplicationInsights.Tests/TelemetryConfigurationSetExporterOptionsTests.cs | Comprehensive test suite with 18 test methods covering all new configuration methods, including validation, error handling, and chaining scenarios |
| .publicApi/Microsoft.ApplicationInsights.dll/Stable/PublicAPI.Unshipped.txt | Documents the six new public APIs for API compatibility tracking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This adds some public apis to configure AzureMonitorExporterOptions from @Microsoft.ApplicationInsights 3.x
See issue