Skip to content

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 6, 2026

Resolves #191

Successful test of the release flow in this build.

Summary by CodeRabbit

  • Chores
    • Enhanced the release workflow to dynamically determine build image tags based on version parameters instead of using a fixed configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@ggiguash ggiguash requested a review from a team as a code owner January 6, 2026 08:23
@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

The release workflow now dynamically computes the bootc image tag based on the release version. A new step parses the git reference to determine which bootc stream to use, defaulting to stream10 but downgrading to stream9 for older release-4.x versions, then passes this value to the build step.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/release.yaml
Adds "Determine bootc stream version" step that computes bootc-image-tag conditionally based on ushift-gitref input (stream10 default, stream9 for release-4.x with yver < 21); updates build step to consume computed tag instead of hard-coded value

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: fixing the release procedure to use CentOS Stream 9 for 4.20 and older versions, which matches the core objective of the PR.
Linked Issues check ✅ Passed The PR implements the requested feature from issue #191 by dynamically determining the bootc image tag (defaulting to stream10, downgrading to stream9 for older release versions), enabling successful builds on CentOS Stream 9 for version 4.20.
Out of Scope Changes check ✅ Passed All changes are scoped to the release workflow file and directly address the issue of fixing 4.20 builds by conditionally selecting the appropriate CentOS Stream version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ggiguash ggiguash marked this pull request as draft January 6, 2026 08:27
@ggiguash
Copy link
Contributor Author

ggiguash commented Jan 6, 2026

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kasturinarra
Copy link

/lgtm

@ggiguash ggiguash marked this pull request as ready for review January 6, 2026 11:18
@ggiguash ggiguash merged commit 1045975 into microshift-io:main Jan 6, 2026
8 of 10 checks passed
@ggiguash ggiguash deleted the fix-420-builds branch January 6, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The 4.20 builds are broken on CentOS 10 platform due to RPM dependencies

2 participants