unix-ffi: Remove ip add/drop membership from socket. #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the IP_ADD_MEMBERSHIP and IP_DROP_MEMBERSHIP since they are now defined in the builtin socket module, because they vary across systems. Depends on: micropython/micropython#18459 Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
dpgeorge
force-pushed
the
feat/remove_ip_add_drop_membership_unix-ffi
branch
from
1e693fd to
ab6dfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
IP_ADD_MEMBERSHIPandIP_DROP_MEMBERSHIPinunix-ffi/socket.pysince they are being defined inusocketin the on the main micropython repository in the following PR if merged.Depends on: micropython/micropython#18459