Skip to content

Conversation

@cansurmeli
Copy link

No description provided.

@cansurmeli
Copy link
Author

Is this project not maintained anymore?

@michaeldorner
Copy link
Owner

michaeldorner commented Sep 17, 2018

Sorry for the delay and thanks for the PR and reminder.

  • Are the icons made by you? They are great!
  • Can you make the commits smaller and coherent? I have some remarks regarding the coding (such as that I want to avoid shortcuts such as *VC for *ViewController).
  • What is your intention to add another layer/subfolder Model?

@cansurmeli
Copy link
Author

cansurmeli commented Sep 19, 2018

  • I got the icon from here. Back when I first got the icon, I checked, there were no licensing issues. Checked again now and saw that I didn't miss anything.
  • Yeah, you're right. It was my laziness. I rebased my fork with smaller/coherent commit logs.
  • Changed VC to ViewController. As a long time Apple ecosystem developer, I think abbreviations like those are needed but I guess for such an open source project like BeeTee, it's better not to stick to abbreviations.
  • I think MVC serves well for iOS projects, even though there is a lot of hype now not do so. I think all that's needed is a good grasp on MVC fundamentals and some experience to make it work. So with the structuring I've done, IMHO, it tells what does what more vividly.

@michaeldorner
Copy link
Owner

michaeldorner commented Sep 27, 2018

Thanks for the update and hard work. Can you please clean up the duplicated files in all subfolders?

@cansurmeli
Copy link
Author

Sorry about the duplicated files. Rebasing. 😐 Should've checked myself.

I also did a Swift 4.2 update but now Travis is reporting a failure!

updated to Xcode 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants