-
-
Notifications
You must be signed in to change notification settings - Fork 32
Update README.md #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Greg-Boggs
wants to merge
1
commit into
mglaman:main
Choose a base branch
from
Greg-Boggs:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update README.md #40
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where would someone run this? The project wasn't intended to be attached to a Drupal project, but rather as a global CLI command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user would run this on any project they are working on where they want access to the command. Does the tool have use for other projects like WordPress or Symphony based ones? If so, then the desired version would be added to the composer file for those projects with the same command.
https://www.sitepoint.com/composer-global-require-considered-harmful/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brew has some advantages over composer in this regard because it has access to the OS outside of the home folder and doesn't get tied to the dependencies of project based work. But, brew is also a real pain in the neck to maintain for an end user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, lets say, I have two projects, a WordPress one and a Drupal one. Both have different tools. But, both sets of tools share a dependency on a base library common to many tools. However, Drupal requires version 2 or lower of the dependency and WordPress requires version 3 or higher. If I'm putting tool dependencies in global, there is no path forward and I simply can't work on Drupal and WordPress together on one machine if they share dependencies and aren't on the same versions for their requirements.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Brew, every project's dependencies are separate even when a tool is installed in a global path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why I suggest primarily downloading the Phar from
https://github.com/mglaman/drupalorg-cli/releases/latest. I can add a self-updaterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about suggesting CGR instead - https://github.com/consolidation/cgr