Improvements to build and publish configuration #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove setup.py in favor of PEP 517 build via pyproject.toml - Update GitHub Actions (checkout, setup-python) to v6 - Simplify release workflow to use 'poetry build' - Move pytest and jinja2 to dev-dependencies - Add dist/ to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the project requires installing jinja2, pytest, setuptools, build, and wheel. jinja2, pytest, and setuptools were installed because they were defined as normal dependencies in pyproject.toml. The build workflow also called "poetry add" for build and wheel dependencies before creating the package, which made them end up in the requirements as well. This PR fixes those issues and also moves to a modern PEP 517 build process (using setup.py as a script is deprecated).
I tested the publishing workflow in my own fork against test-pypi (workflow run logs) and everything worked after changes.