Feature/max memory disk store #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d cell store for handling large files, effectively limiting memory usage. This change follows the guidance of using the `xlsx` library's built-in `UseDiskVCellStore` feature. When the `--max-memory` flag is present, the application will now use temporary files on disk to store cell data, which significantly reduces the memory footprint when processing large CSV files. The development process involved several iterations to arrive at this correct solution, which leverages the library's intended functionality for handling large datasets. Key changes: - Added a `--max-memory` boolean flag to `command_line.go`. - Modified `write.go` to conditionally use `xlsx.UseDiskVCellStore` when creating or opening an XLSX file if the `--max-memory` flag is set. - Added a new test case in `main_test.go` to validate that large files can be processed successfully with this option enabled. The test programmatically creates the test data. - Added the generated test file `dummy_large.csv` to `.gitignore`. - Updated `README.md` to document the new flag.
… cell store for handling large files, effectively limiting memory usage. This change follows the guidance of using the `xlsx` library's built-in `UseDiskVCellStore` feature. When the `--use-cache` flag is present, the application will now use temporary files on disk to store cell data, which significantly reduces the memory footprint when processing large CSV files. The flag was renamed from `--max-memory` to `--use-cache` to more accurately reflect its function. Key changes: - Renamed the `--max-memory` flag to `--use-cache` in `command_line.go`. - Modified `write.go` to conditionally use `xlsx.UseDiskVCellStore` when the `--use-cache` flag is set. - Updated tests in `main_test.go` to use the new flag and test the disk-based storage functionality. - Added benchmark tests (`BenchmarkBuildXls_InMemory` and `BenchmarkBuildXls_DiskV`) to compare the in-memory and disk-based storage solutions. - Added generated test files to `.gitignore` to keep the repository clean. - Updated `README.md` to document the new `--use-cache` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix [#35]