Skip to content

Conversation

@arushi2702
Copy link

Description

This PR solves the first out of two tasks given in Issue #1968 . The content from cht-conf repo's README file that was initially missing from the documnetation site has been added.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Copy link
Contributor

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good - thanks @arushi2702 !

I've added some early feedback, but otherwise take your time and ping me when you're ready for a formal review.

### Zsh completion
To enable tab completion in zsh, add the following to your `~/.zshrc` file:
```shell
eval "$(cht-conf --shell-completion=zsh)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the command is actually cht:

Suggested change
eval "$(cht-conf --shell-completion=zsh)"
eval "$(cht --shell-completion=zsh)"

- `--skip-git-check` – Skip repository status check
- `--skip-translation-check` – Skip checking message translations
- `--skip-validate` – Skip form validation
- `--force` – Automatically answer yes to all prompts; overwrite changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give another pass on these to make them more helpful and more explicit? Think about why the user would want to use these flags? What scenarios might they be needed? What are the risks or benefits of using some of these?

for example:

 `--accept-self-signed-certs` – Allow self-signed certificates

is just re-wording the flag and not adding any more information. Here's what I might do as an example (and feel free to use it verbatim so you get a freebie ;)

 `--accept-self-signed-certs` – By default `cht` command will expect a valid TLS certificate on the CHT instance.  However, sometimes there's an invalid self-signed certficate on a development instance.  In this case, pass this flag so that `cht` will ignore any TLS errors when connecting to the CHT instance.

@arushi2702
Copy link
Author

Thank you for the feedback! Working on it.

@andrablaj
Copy link
Member

Hi @arushi2702! Any updates on this PR? Did you manage to apply the feedback you received?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants