-
Notifications
You must be signed in to change notification settings - Fork 1
Document review #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RikkeVestesen
wants to merge
74
commits into
develop
Choose a base branch
from
2025-08-20-ECG
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
21c78dd
Added dependency to IHEM HD
RikkeVestesen 4037d9c
Added DK-core DocumentReference + MHD MinialDocumentReference
RikkeVestesen 1839941
Added Basic DocumentReference
RikkeVestesen 1e884f9
Udated dependencies
RikkeVestesen 50f54e8
Updated dependencies
RikkeVestesen 5fd797e
Added obligation helpers
RikkeVestesen 2168b78
Commented on DocumentReference
RikkeVestesen 365d30b
Updated DocRefs
RikkeVestesen ee1b494
Corrected docref
RikkeVestesen efe7aa3
Update MedComContainedDocumentReference.fsh
RikkeVestesen 8b0643e
Updated
RikkeVestesen 5f42fb5
Updated
RikkeVestesen ef15cb1
Updated
RikkeVestesen f718622
Update MedComContainedDocumentReference.fsh
RikkeVestesen 7a4e573
Correccted dependencies
RikkeVestesen ba4c780
Added comments
RikkeVestesen 49143a1
Updated event
RikkeVestesen a724bad
Updated comment
RikkeVestesen 9463019
Update MedComContainedDocumentReference.fsh
RikkeVestesen a147f1c
Create MedComDocumentAuthorInstitutionOrganization.fsh
SGA-MedCom 294817d
Ændret til DEV og teste med author[person]
SGA-MedCom 9c445f0
Updated
RikkeVestesen ad250ae
Updated
RikkeVestesen 3321e00
Updated
RikkeVestesen 60cb2fa
Updated
RikkeVestesen b4d4200
added
RikkeVestesen 70a3932
Updated authenticator and attester
RikkeVestesen 6696cf7
Corrected creation and language
RikkeVestesen c5f7046
udated
RikkeVestesen ecd0760
Spelling error
RikkeVestesen 808bcdb
Update MedComDocumentBundle.fsh
RikkeVestesen 0e3d1cb
Added DocumentPractitionerRole
RikkeVestesen c8231a1
added MedComContentDocumentReference and datetime invariant
RikkeVestesen 1743d04
Updated medcom-uuidv4
RikkeVestesen eaa9b31
added
RikkeVestesen 9e1ab68
Updated creationTime
RikkeVestesen 5915cc4
spelling error
RikkeVestesen 4e412aa
Updated invariant for UUID4
RikkeVestesen 905e238
moved comment
RikkeVestesen ee5974d
Added type short
RikkeVestesen 439fd8a
Updated composition
RikkeVestesen 767ed99
Removed homecommunityid, added MS to extension and updated identifier
RikkeVestesen 16a8c7c
Edited identifiers
RikkeVestesen cc61f4e
Update MedComContainedDocumentReference.fsh
RikkeVestesen 37ac166
Fjerne slice for healthcareFacilityTypeCode og practiceSettingCode
SGA-MedCom 8cab2e3
updated comment
RikkeVestesen 11cbb6e
Updated
RikkeVestesen c809c56
Updated
RikkeVestesen aec7d74
updated
RikkeVestesen 660bf40
Update MedComContainedDocumentReference.fsh
RikkeVestesen 4e9fbb2
Updated DocRef and Composition
RikkeVestesen 31af072
Updated
RikkeVestesen 1e7675a
Updated
RikkeVestesen 05f240c
Updated
RikkeVestesen 829f3f8
Updated
RikkeVestesen 33a07dd
Updated
RikkeVestesen 846e117
comment removed
RikkeVestesen d1ef87d
Updated texts
RikkeVestesen 6629dbb
Updated texts
RikkeVestesen 6824383
Corrected UML diagram
RikkeVestesen 3605be6
updated texts and author
RikkeVestesen 95ab1f5
Updated
RikkeVestesen ab9d3d2
Updated dependency to terminology
RikkeVestesen bee225b
Corrected category to 0..1 for composition
RikkeVestesen 4db0363
Updated obligations
RikkeVestesen 23692d9
Added description for patient and documentreference
RikkeVestesen c418344
Added link to mapping in profiles
RikkeVestesen 9d9978f
Update StructureDefinition-medcom-document-composition-intro.md
RikkeVestesen 745a0bb
added ignorewarning expression
RikkeVestesen 1092d01
testing build-site
RikkeVestesen 21d4948
Undo test
RikkeVestesen 4dfdac1
Updated according to review
RikkeVestesen d34e0d9
Added invariant for formatcode semantinc versioning
RikkeVestesen ef433e2
Update invariants.fsh
RikkeVestesen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| RuleSet: ProducerShallPutInNarrative(elementName) | ||
| * {elementName} ^extension[$obligation][+].extension[code].valueCode = #SHALL:in-narrative | ||
| * {elementName} ^extension[$obligation][=].extension[actor].valueCanonical = Canonical(ProducerActor) | ||
|
|
||
| Instance: ProducerActor | ||
| InstanceOf: ActorDefinition | ||
| * name = "Producer of FHIR resources" | ||
| * title = "Producer of FHIR resources" | ||
| * status = #active | ||
| * type = #system | ||
| * description = "The system that creates the FHIR resources" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| Profile: MedComContainedDocumentReference | ||
| Parent: MedComMinimalDocumentReference //OBS: Nedarv direkte fra DkCore når den udgives | ||
| Id: medcom-contained-documentreference | ||
| Description: "A profile stating the rules, when exchanging a FHIR document in the Danish Healthcare sector using IHE MHD and IHE XDS based document sharing." | ||
| * id 1.. MS | ||
| * text MS | ||
| * text ^short = "The narrative text SHALL always be included when exchanging a MedCom FHIR Bundle." | ||
| * text.status MS | ||
| * text.div MS | ||
|
|
||
| // uniqueId | ||
| * masterIdentifier 1..1 MS | ||
| * masterIdentifier.value 1..1 MS | ||
| * masterIdentifier ^short = "[DocumentEntry.uniqueId] Master Version Specific Identifier" | ||
|
|
||
| // entryUUID | ||
| * identifier[entryUUID] 1..1 MS | ||
| * identifier[entryUUID].value 1..1 MS | ||
| * identifier[entryUUID].system 1..1 MS //https://profiles.ihe.net/ITI/MHD/4.2.2/StructureDefinition-IHE.MHD.EntryUUID.Identifier.html | ||
| * identifier[entryUUID] ^short = "[DocumentEntry.entryUUID] Identifier for the document" | ||
| * identifier[entryUUID].value obeys medcom-uuid | ||
| * status MS | ||
| * status ^short = "[DocumentEntry.availabilityStatus] current = active | superseded = deprecated" | ||
| // TypeCode | ||
| * type 1.. MS | ||
| * type ^short = "[DocumentEntry.typeCode] Kind of document" | ||
| * type.coding 1.. MS | ||
| * type.coding.system 1.. MS | ||
| * type.coding.code 1.. MS | ||
| * type.coding.display 1.. MS | ||
| * type from $TypeCode (required) | ||
| * authenticator 0..1 MS | ||
| * authenticator ^short = "[DocumentEntry.legalAuthenticator] Who authenticated the document." | ||
| * authenticator only Reference(MedComDocumentPractitioner) | ||
| * authenticator ^type.aggregation = #contained | ||
| // ClassCode | ||
| * category 1..1 MS | ||
| * category from $ClassCode (extensible) | ||
| * category.coding.code 1.. MS | ||
| * category.coding.system 1.. MS | ||
| * category.coding.display 1.. MS | ||
| * category ^short = "[DocumentEntry.classCode] Categorization of document" | ||
| * author ..2 MS | ||
| * author only Reference(MedComDocumentOrganization or MedComDocumentPractitionerRole or MedComDocumentPractitioner or MedComDocumentPatient or DkCoreRelatedPerson or Device) | ||
| * author ^slicing.discriminator[0].type = #profile | ||
| * ^slicing.discriminator[0].path = "$this.resolve()" | ||
| * ^slicing.rules = #open | ||
| * author contains | ||
| institution 1..1 MS | ||
| * author ^short = "[DocumentEntry.author] The slice author:institution ensures one mandatory organizational author. | ||
| Any author element that does not match this slice is interpreted | ||
| as an author person." | ||
| * author[institution] only Reference(MedComDocumentOrganization) | ||
| * author[institution] ^short = "The organization who authored the document." | ||
| * author ^type.aggregation = #bundled | ||
| * securityLabel 1..1 MS | ||
| * securityLabel.coding 1..1 MS | ||
| * securityLabel.coding.system 1.. MS | ||
| * securityLabel.coding.code 1.. MS | ||
| * securityLabel ^short = "[DocumentEntry.confidentialityCode] Document security-tags" | ||
| * subject MS | ||
| * subject only Reference(MedComDocumentPatient) | ||
| * subject ^type.aggregation = #contained | ||
| * subject ^short = "[DocumentEntry.sourcePatientInfo, DocumentEntry.sourcePatientId] Who/what is the subject of the document" | ||
| * content.attachment.creation ^short = "[DocumentEntry.creationTime] Date attachment was first created" | ||
| * content.attachment.creation 1.. MS | ||
| * content.attachment.creation obeys medcom-datetime-has-time-zulu | ||
| * content MS | ||
| * content.attachment.contentType ^short = "[DocumentEntry.mimeType] Mime type of the content, with charset etc." | ||
| * content.attachment.contentType 1.. MS | ||
| * content.attachment.contentType from $ContentType | ||
| * content.attachment MS | ||
| * content.attachment.language ^short = "[DocumentEntry.languageCode] Human language of the content" | ||
| * content.attachment.language 1.. MS | ||
| * content.attachment.language from $Language (extensible) | ||
| * content.attachment.hash 0.. MS | ||
| * content.attachment.hash ^short = "[DocumentEntry.hash] Hash of the data (sha-1)" | ||
| * content.format ^short = "[DocumentEntry.formatCode] Format/content rules for the document" | ||
| * content.format 1.. MS | ||
| * content.format.system 1.. MS | ||
| * content.format.code 1.. MS | ||
| * content.format.display 1.. MS | ||
| * content.format from $FormatCode (required) | ||
| * content.attachment.size 0.. MS | ||
| * content.attachment.title 1.. MS | ||
| * content.attachment.url MS | ||
| * content.attachment.size ^short = "[DocumentEntry.size] Number of bytes of content." | ||
| * content.attachment.title ^short = "[DocumentEntry.title] The readable title of the document." | ||
| * content.attachment.url ^short = "[DocumentEntry.URI] URI where the data can be found." | ||
| * context 1.. MS | ||
| * context.event 0.. MS | ||
| * context.event.coding.code 1.. MS | ||
| * context.event.coding.system 1.. MS | ||
| * context.event ^short = "[DocumentEntry.eventCodeList] Main clinical acts documented." | ||
| * context.period MS | ||
| * context.period.start 1.. MS | ||
| * context.period.end MS | ||
| * context.period ^short = "[DocumentEntry.serviceStartTime, DocumentEntry.serviceStopTime] Time of service that is being documented." | ||
| * context.facilityType 1.. MS | ||
| * context.facilityType.coding 1..1 MS | ||
| * context.facilityType.coding.code 1.. MS | ||
| * context.facilityType.coding.system 1.. MS | ||
| * context.facilityType.coding.display 1.. MS | ||
| * context.facilityType from $FacilityType (required) | ||
| * context.facilityType ^short = "[DocumentEntry.healthcareFacilityTypeCode] Kind of facility where patient was seen." | ||
| * context.practiceSetting 1.. MS | ||
| * context.practiceSetting.coding 1..1 MS | ||
| * context.practiceSetting.coding.code 1.. MS | ||
| * context.practiceSetting.coding.system 1.. MS | ||
| * context.practiceSetting.coding.display 1.. MS | ||
| * context.practiceSetting from $PracticeSetting (required) | ||
| * context.practiceSetting ^short = "[DocumentEntry.practiceSettingCode] Additional details about where the content was created (e.g. clinical specialty)." | ||
| * context.related 0..* MS | ||
| * context.related ^short = "[DocumentEntry.referenceIdList] Related identifiers or resources." | ||
| * context.sourcePatientInfo 1..1 MS | ||
| * context.sourcePatientInfo.reference 1.. MS | ||
| * context.sourcePatientInfo.identifier 1.. MS | ||
| * context.sourcePatientInfo ^short = "[DocumentEntry.sourcePatientId and DocumentEntry.sourcePatientInfo] Patient demographics from source. Must be the same reference as in DocumentReference.subject." | ||
| * context.sourcePatientInfo only Reference(MedComDocumentPatient) | ||
| * extension MS | ||
| * extension[versionid] MS | ||
| * extension[versionid] ^short = "Specifies the version of the DocumentReference profile for a standard." | ||
|
|
||
| * insert ProducerShallPutInNarrative(id) | ||
| * insert ProducerShallPutInNarrative(author[institution]) | ||
| * insert ProducerShallPutInNarrative(author) | ||
| * insert ProducerShallPutInNarrative(subject) | ||
| * insert ProducerShallPutInNarrative(status) | ||
| * insert ProducerShallPutInNarrative(type.coding.system) | ||
| * insert ProducerShallPutInNarrative(type.coding.code) | ||
| * insert ProducerShallPutInNarrative(type.coding.display) | ||
| * insert ProducerShallPutInNarrative(authenticator) | ||
| * insert ProducerShallPutInNarrative(category.coding.code) | ||
| * insert ProducerShallPutInNarrative(category.coding.system) | ||
| * insert ProducerShallPutInNarrative(category.coding.display) | ||
| * insert ProducerShallPutInNarrative(identifier[entryUUID].value) | ||
| * insert ProducerShallPutInNarrative(identifier[entryUUID].system) | ||
| * insert ProducerShallPutInNarrative(securityLabel.coding.code) | ||
| * insert ProducerShallPutInNarrative(securityLabel.coding.system) | ||
| * insert ProducerShallPutInNarrative(content.attachment.creation) | ||
| * insert ProducerShallPutInNarrative(content.attachment.contentType) | ||
| * insert ProducerShallPutInNarrative(content.attachment.language) | ||
| * insert ProducerShallPutInNarrative(content.format.system) | ||
| * insert ProducerShallPutInNarrative(content.format.code) | ||
| * insert ProducerShallPutInNarrative(content.format.display) | ||
| * insert ProducerShallPutInNarrative(content.attachment.size) | ||
| * insert ProducerShallPutInNarrative(content.attachment.title) | ||
| * insert ProducerShallPutInNarrative(content.attachment.url) | ||
| * insert ProducerShallPutInNarrative(context.event.coding.code) | ||
| * insert ProducerShallPutInNarrative(context.event.coding.system) | ||
| * insert ProducerShallPutInNarrative(context.period.start) | ||
| * insert ProducerShallPutInNarrative(context.period.end) | ||
| * insert ProducerShallPutInNarrative(context.facilityType.coding.code) | ||
| * insert ProducerShallPutInNarrative(context.facilityType.coding.system) | ||
| * insert ProducerShallPutInNarrative(context.facilityType.coding.display) | ||
| * insert ProducerShallPutInNarrative(context.practiceSetting.coding.code) | ||
| * insert ProducerShallPutInNarrative(context.practiceSetting.coding.system) | ||
| * insert ProducerShallPutInNarrative(context.practiceSetting.coding.display) | ||
| * insert ProducerShallPutInNarrative(context.related) | ||
| * insert ProducerShallPutInNarrative(context.sourcePatientInfo.reference) | ||
| * insert ProducerShallPutInNarrative(context.sourcePatientInfo.identifier) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Profile: MedComDocumentCareTeam | ||
| Parent: MedComCoreCareTeam | ||
| Id: medcom-document-careteam | ||
| Description: "Careteam participating in the care of a patient." | ||
| * identifier 1..1 MS | ||
| * identifier.value 1..1 MS | ||
| * identifier.system 1..1 MS | ||
| * identifier ^short = "Globally unique, stable identifier for this resource. The same identifier SHALL be used when this resource is recreated from the same source data." | ||
| * managingOrganization only Reference(MedComDocumentOrganization) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Profile: MedComDocumentObservation | ||
| Parent: MedComCoreObservation | ||
| Id: medcom-document-observation | ||
| Title: "MedComDocumentObservation" | ||
| Description: "Observation profile to be used in MedCom FHIR Documents." | ||
| * identifier 1..1 MS | ||
| * identifier.value 1..1 MS | ||
| * identifier.system 1..1 MS | ||
| * identifier ^short = "Globally unique, stable identifier for this resource. The same identifier SHALL be used when this resource is recreated from the same source data." | ||
| * subject only Reference(MedComDocumentPatient) | ||
| * performer only Reference(MedComDocumentOrganization or MedComDocumentPractitioner or MedComDocumentPractitionerRole or MedComDocumentCareTeam or MedComDocumentPatient or DkCoreRelatedPerson) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hvad er årsagen til at 'author:person'-slices er fjernet? er det ikke meget fint at sætte krav til, at det skal være en practitioner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det er ifølge XDS metadatastandarden muligt at andre end end pracitioner kan være author:person. Det kan også være alle andre profiler jeg har indsat under author elementet inden slicing. Problemet er, at man ikke kan lave en slice der tillader at det kan være flere forskellige ressourcer-/profilertyper der kan tillades i samme slice. Derfor har jeg skrevet, at hvis man indsætter en author ud over organisationen, så skal den opdattes oms author:person, selvom det ikke er en slice.
Kan du se en bedre løsning?