Skip to content

Conversation

@multiplemonomials
Copy link
Collaborator

Summary of changes

This is a followup to my earlier Pydantic schemas PR. It fixes all of the hundreds of warnings that are now being printed about options with incorrectly formatted names.

There should (TM) be no code impacts from this change, as the configuration system will "normalize" names into the new format, so you can still e.g. override a option with the old name containing underscores. However, I did find a minor bug in the previous PR, which is that it didn't handle the case of options with underscores in their namespaces. That has been fixed here.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed as this is available in its own repository: https://github.com/PelionIoT/mbed-client-cli

"spi-cs": "SPI_CS",
"spi-mosi": "SPI_MOSI",
"spi-miso": "SPI_MISO",
"spi-clk": "spi-sck"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like the rest - spi-sck vs SPI_SCK

Copy link
Collaborator Author

@multiplemonomials multiplemonomials Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch! That was a bad find and replace, fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants