-
Notifications
You must be signed in to change notification settings - Fork 28
Remove underscores and capitals from all JSON options #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been removed as this is available in its own repository: https://github.com/PelionIoT/mbed-client-cli
| "spi-cs": "SPI_CS", | ||
| "spi-mosi": "SPI_MOSI", | ||
| "spi-miso": "SPI_MISO", | ||
| "spi-clk": "spi-sck" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not look like the rest - spi-sck vs SPI_SCK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch! That was a bad find and replace, fixed now
Summary of changes
This is a followup to my earlier Pydantic schemas PR. It fixes all of the hundreds of warnings that are now being printed about options with incorrectly formatted names.
There should (TM) be no code impacts from this change, as the configuration system will "normalize" names into the new format, so you can still e.g. override a option with the old name containing underscores. However, I did find a minor bug in the previous PR, which is that it didn't handle the case of options with underscores in their namespaces. That has been fixed here.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results