-
Notifications
You must be signed in to change notification settings - Fork 28
Update all STM32 HALs as submodules #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Refactor CMSIS path references in cmake file Message call for debug was removed
- Resolved mbed_lib.json conflict by using master version - Resolved modify/delete conflicts: kept deletions (files moved to submodules) - Ready for pull request submission
|
I did some research about applied patches in old HALs, how Jamie recommended.
This similar patch was applied for F2,F4,F7,H7 in the past.
Affected files were xxx_hal_dma.c or/and xxx_hal_dma_ex.c is some cases.
The fix aplied in xxx_hal_dma_ex.c is in function HAL_DMAEx_MultiBufferStart_IT what is called only in HAL_DCMI_Start_DMA. However I did not found any other calls of these functions across Mbed. The fix aplied in xxx_hal_dma.c is in function HAL_DMA_Start_IT that is used across many peripherals. But ST's employee gave an answer to Jamie about the issue should be solved in HAL PPP drivers and really in STM32H7 SPI HAL driver is same function (SPI_DMAError) like the guy from ST posted. Unfortunately this functions was there years ago, so question is if this is really a solution... @multiplemonomials Mbed releted seems to be only implementation of STM32F7 because only for this one I found a conection to Mbed drivers. Of course I can be wrong and missed something. |
|
OK I did a little digging, and you are right, this seems to be STM32F7 specific. The H7 HAL has this line: https://github.com/STMicroelectronics/stm32h7xx-hal-driver/blob/8bd31106a890ae7254f757bbe55d467a52cc8e03/Src/stm32h7xx_hal_spi.c#L3523 Which would appear to prevent this issue from happening. I didn't realize this when I filed the issue on the H7 repo. But the F7 HAL does not: https://github.com/STMicroelectronics/stm32f7xx-hal-driver/blob/40630a2df5e6a0536e0fb37c39a4fb968f3364d4/Src/stm32f7xx_hal_spi.c#L3375 So we will need to keep this patch applied for STM32F7 (and any others that do not have that if statement but do have FIFO error flags). Maybe you could file an issue on that repo linking to my original issue? |

Summary of changes
This PR brings update of all STM32 HALs and moreover HALs of all families were switched to submodules. That brings possibility of easy switch between HAL versions, easy update and save a lot of disk space.
Impact of changes
When some patches will be necessary then we will use this approach.
STM32Cube_FW\Mbed_HAL_overridesFor examples see STM32G4
Migration actions required
Documentation
Pull request type
Test results