Nuvoton: M487: Fix reset loop with target.wdt-reset-workaround #526
+18
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may trap in DPD/SPD wake-up reset loop when multi-level bootloaders (e.g. LDROM and MCUBoot) and application all or partial integrate this workaround. To avoid this, the wake-up flag CLK_PMUSTS_TMRWK_Msk is used to guard from duplicate wake-up reset setups and the clear-up of this flag is delayed to hal_watchdog_init, which will be invoked via Mbed Watchdog API. This approach works based on the assumptions: 1. Only application will set up WDT. LDROM and MCUBoot won't. 2. WDT setup is done via Mbed Watchdog API, not direct WDT control.
ccli8
force-pushed
the
nvt_m487_fix_wakeup_reset_loop
branch
from
0779ca0 to
c710bad
Compare
| * by bootloader or by application, but not both. | ||
| */ | ||
| if (SYS->RSTSTS & ALL_RESET_FLAGS) { | ||
| do { |
Collaborator
There was a problem hiding this comment.
Any reason not to just remove the do...while(0) loop and just move this code to the outer scope?
multiplemonomials
approved these changes
Dec 19, 2025
Collaborator
multiplemonomials
left a comment
multiplemonomials
left a comment
There was a problem hiding this comment.
Looks good except for that one comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is follow-up of #519. We may trap in DPD/SPD wake-up reset loop when multi-level bootloaders (e.g. LDROM and MCUBoot) and application all or partial integrate this workaround. To avoid this, the wake-up flag
CLK_PMUSTS_TMRWK_Mskis used to guard from duplicate wake-up reset setups and the clear-up of this flag is delayed tohal_watchdog_init, which will be invoked via Mbed Watchdog API.This approach works based on the assumptions:
Pull request type