Fix login API called when MSC4190 enabled #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither the GET nor POST variants of the Synapse `/login` API should be called when support for MSC4190 is enabled: https://areweoidcyet.com/ Fixes: mautrix/telegram#1020
Author
|
Oops, didn't realise there was a PR for this already at #178. Closing this in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither the GET nor POST variants of the Synapse
/loginAPI should be called when support for MSC4190 is enabled: https://areweoidcyet.com/Fixes: mautrix/telegram#1020
I tested this by cloning the Telegram bridge locally and using my forked branch instead of the normal Mautrix library. After doing that I was able to once again use the local (non-public) address for my Synapse server and it correctly used the MSC4190 code instead of the
/loginendpoint. I was able to interact with Telegram normally from both the TG and Matrix sides.