Skip to content

Conversation

@raghavaggarwal2308
Copy link

@raghavaggarwal2308 raghavaggarwal2308 commented Jan 18, 2024

Summary

  • Updated log statements
  • Removed unnecessary logs

@codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 144 lines in your changes missing coverage. Please review.

Project coverage is 33.40%. Comparing base (53b10f3) to head (ad68089).
Report is 40 commits behind head on master.

Files with missing lines Patch % Lines
server/plugin.go 23.70% 101 Missing and 2 partials ⚠️
server/api.go 0.00% 40 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   34.02%   33.40%   -0.62%     
==========================================
  Files          22       22              
  Lines        4021     4185     +164     
==========================================
+ Hits         1368     1398      +30     
- Misses       2515     2647     +132     
- Partials      138      140       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raghavaggarwal2308
Copy link
Author

@mickmister Gentle reminder for review

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 6, 2024
@mickmister
Copy link
Contributor

I'm not sure if we should go through with this logging approach in general. @hanzei What are your thoughts on this?

@hanzei
Copy link
Collaborator

hanzei commented Mar 15, 2024

The diff looks off. Maybe the PR needs to get rebased onto verbose-logging-for-token-debugging?

@raghavaggarwal2308
Copy link
Author

@hanzei The branch MM-147 is in sync with the base branch. We have removed some unnecessary log statements from the code in this PR.

@mickmister
Copy link
Contributor

@raghavaggarwal2308 We can have this PR point to master instead

@raghavaggarwal2308 raghavaggarwal2308 changed the base branch from verbose-logging-for-token-debugging to master March 28, 2024 07:28
@raghavaggarwal2308
Copy link
Author

@mickmister updated

@raghavaggarwal2308 raghavaggarwal2308 added the Do Not Merge Should not be merged until this label is removed label Nov 29, 2024
@abbas-dependable-naqvi
Copy link
Contributor

Can be merged after conflict resolution if still required

@raghavaggarwal2308
Copy link
Author

raghavaggarwal2308 commented Oct 31, 2025

@wiggin77
SUMMARY:
This PR was created to add some logs to debug this #411 issue. I think @mickmister shared a build for this with the client.
The issue is still open.
Keeping this PR open in case anyone is trying to debug the issue any further

@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Nov 3, 2025
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer Awaiting Submitter Action Blocked on the author Do Not Merge Should not be merged until this label is removed Lifecycle/1:stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants