Skip to content

Conversation

@hanzei
Copy link
Contributor

@hanzei hanzei commented Apr 10, 2025

Summary

  • Remove CircleCI configuration
  • Add GitHub Actions workflow for shellcheck

🤖 Generated with Claude Code

- Remove CircleCI configuration
- Add GitHub Actions workflow for shellcheck

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@hanzei hanzei requested a review from mrckndt April 10, 2025 10:16
- Fix variable quoting issues to prevent globbing and word splitting
- Fix variable reference typo (POSTGRES_POSTGRES_NEW_VERSION → POSTGRES_NEW_VERSION)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Apr 10, 2025
if [[ $POSTGRES_UPGRADE_LINE == "" ]]; then
echo "no exported POSTGRES_UPGRADE_LINE environment variable found"
echo "setting POSTGRES_UPGRADE_LINE to default $POSTGRES_OLD_VERSION-to-$POSTGRES_POSTGRES_NEW_VERSION"
echo "setting POSTGRES_UPGRADE_LINE to default $POSTGRES_OLD_VERSION-to-$POSTGRES_NEW_VERSION"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue 🤔

@hanzei hanzei requested a review from ewwollesen April 10, 2025 14:09
@hanzei hanzei requested a review from svelle May 16, 2025 09:32
Copy link
Member

@svelle svelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my limited understanding of circleci and gh actions this looks good to merge.

@hanzei
Copy link
Contributor Author

hanzei commented May 16, 2025

This will have to do it then 😉

@hanzei hanzei added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels May 16, 2025
@hanzei hanzei merged commit 7d9d7bf into main May 16, 2025
1 check passed
@hanzei hanzei deleted the migrate-to-github-actions branch July 21, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants