Skip to content

Conversation

@kaylendog
Copy link
Contributor

@kaylendog kaylendog commented Dec 19, 2025

  • Introduces a new enum ForwarderData as a wrapper for valid variants of SenderData for which we can accept key bundles under MSC4268.

  • Converts forwarder_data in InboundGroupSession and PickledInboundGroupSession to use Option<ForwarderData> over Option<SenderData>.

  • Public API changes documented in changelogs (optional)

@kaylendog kaylendog self-assigned this Dec 19, 2025
@kaylendog kaylendog force-pushed the kaylendog/history-sharing/forwarder-info branch 4 times, most recently from f67cd3e to f03ac5e Compare December 19, 2025 13:28
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #5980 will not alter performance

Comparing kaylendog/history-sharing/forwarder-info (cce6533) with main (c3c367c)

Summary

✅ 50 untouched

Signed-off-by: Skye Elliot <actuallyori@gmail.com>
@kaylendog kaylendog force-pushed the kaylendog/history-sharing/forwarder-info branch from f03ac5e to ef6ee68 Compare December 19, 2025 13:40
@kaylendog kaylendog marked this pull request as ready for review December 19, 2025 13:49
@kaylendog kaylendog requested review from a team as code owners December 19, 2025 13:49
@kaylendog kaylendog requested review from Hywan and richvdh and removed request for a team December 19, 2025 13:49
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (759c5a9) to head (cce6533).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...dk-crypto/src/olm/group_sessions/forwarder_data.rs 78.57% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5980      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         363      364       +1     
  Lines      104020   104075      +55     
  Branches   104020   104075      +55     
==========================================
+ Hits        92114    92155      +41     
- Misses       7528     7538      +10     
- Partials     4378     4382       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@kaylendog kaylendog enabled auto-merge (squash) December 19, 2025 14:39
@kaylendog kaylendog merged commit 42a5910 into main Dec 19, 2025
51 checks passed
@kaylendog kaylendog deleted the kaylendog/history-sharing/forwarder-info branch December 19, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants