Add artifacts templating to bundle new prompt #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryodaniel
approved these changes
Nov 24, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds artifacts templating support to the mass bundle new command, allowing users to specify output artifacts that a bundle will produce. This mirrors the existing connections functionality (which defines inputs).
- Added
Artifactsfield toTemplateDatastruct with correspondingArtifacttype - Renamed connection-related validation functions to use "link" terminology (more generic naming)
- Added
getArtifacts()prompt function and--artifactsCLI flag for non-interactive mode - Fixed unused variable in test code
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/templatecache/template_cache.go | Added Artifacts field to TemplateData and defined new Artifact struct matching the Connection struct pattern |
| pkg/bundle/prompt.go | Renamed connNameValidate → linkNameValidate and related variables; added getArtifacts() function for prompting users about output artifacts |
| pkg/bundle/prompt_test.go | Updated test function names from TestConnNameValidate → TestLinkNameValidate to match renamed function |
| pkg/bundle/publish_test.go | Fixed unused variable warning by removing blank identifier in range loop |
| cmd/bundle.go | Added --artifacts flag and parsing logic to support non-interactive artifact specification |
| docs/generated/mass_bundle_new.md | Added documentation for new --artifacts flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.