Skip to content

refactor writing into storeJson #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marsh69 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor writing into storeJson #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 15 additions & 30 deletions routes/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,18 @@ function readStoreJSON() {
}
readStoreJSON();

function writeIntoStoreJson(store) {
fs.writeFile(
"./db/store.json",
JSON.stringify(store, null, 4),
"utf8",
function cb(err) {
if (err) {
res.status(500).send("Could not save data");
}
}
);
}
// Helper functions

/**
Expand Down Expand Up @@ -216,16 +228,7 @@ router.post("/:entityType", (req, res) => {
newEntity["id"] = id;
entities.push(newEntity);

fs.writeFile(
"./db/store.json",
JSON.stringify(store, null, 4),
"utf8",
function cb(err) {
if (err) {
res.status(500).send("Could not save data");
}
}
);
writeIntoStoreJson(store);
res.send(newEntity);
});
// Update an existing entity rowby id
Expand All @@ -250,15 +253,7 @@ router.put("/:entityType/:id", (req, res) => {
obj.id === mergedEntity.id ? mergedEntity : obj
);

fs.writeFile(
"./db/store.json",
JSON.stringify(store, null, 4),
"utf8",
function cb(err) {
if (err) {
}
}
);
writeIntoStoreJson(store)
res.send(mergedEntity);
});

Expand All @@ -268,17 +263,7 @@ router.delete("/:entityType/:id", (req, res) => {
let id = req.params.id;
if (removeEntityById(store, entityType, id) != -1) {
res.send("Deleted Successfully");

fs.writeFile(
"./db/store.json",
JSON.stringify(store, null, 4),
"utf8",
function cb(err) {
if (err) {
res.status(500).send("Could not save data");
}
}
);
writeIntoStoreJson(store)
} else {
respondWith404(res);
}
Expand Down