-
Notifications
You must be signed in to change notification settings - Fork 13
feat: change order of sequences and add randomize option for street project #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release - 2024-August [Fix]
Release - 2024-August - 2
Release - 2024 October
Fix: usernames missing in firebase
fix missing usernames v2
| return None | ||
| df = filter_by_timerange(df, start_time, end_time) | ||
|
|
||
| if randomize_order is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that we randomize the task order even if randomize_order is False (because not None)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried creating projects with a) no randomizeOrder attribute in the project draft, b) randomizeOrder set to false and c) randomizeOrder set to true. All resulting projects seem to have tasks in random order. I would have expected the randomization only when randomizeOrder is explicitely set to true? Could you please check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with some different project drafts. Tasks were in random order when I provided no samplingThreshold and in sequential order when I set a samplingThreshhold, regardless of the value of randomizeOrder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it works for me. Images are in sequential order when a samplingThreshold is set, unless randomizeOrder is true.
No description provided.