Skip to content

Conversation

@Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Jan 21, 2025

No description provided.

return None
df = filter_by_timerange(df, start_time, end_time)

if randomize_order is not None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that we randomize the task order even if randomize_order is False (because not None)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried creating projects with a) no randomizeOrder attribute in the project draft, b) randomizeOrder set to false and c) randomizeOrder set to true. All resulting projects seem to have tasks in random order. I would have expected the randomization only when randomizeOrder is explicitely set to true? Could you please check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with some different project drafts. Tasks were in random order when I provided no samplingThreshold and in sequential order when I set a samplingThreshhold, regardless of the value of randomizeOrder.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works for me. Images are in sequential order when a samplingThreshold is set, unless randomizeOrder is true.

@ofr1tz ofr1tz merged commit 2d41751 into dev Feb 4, 2025
1 check passed
@ofr1tz ofr1tz deleted the improve-street-project branch February 4, 2025 17:06
@ofr1tz ofr1tz mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants