Skip to content

fix: remove duplicates after spatial sampling #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofr1tz merged 3 commits into from
Mar 4, 2025
Merged

fix: remove duplicates after spatial sampling #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64553ef
fix: remove duplicates after spatial sampling
Gigaszi Feb 24, 2025
809f0f8
fix: handle FutureWarning when concating dfs
Gigaszi Mar 3, 2025
a7319e4
fix: check if column exists before using astype
Gigaszi Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mapswipe_workers/mapswipe_workers/utils/process_mapillary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,14 @@ def get_image_metadata(
raise CustomError(
"No Mapillary Features in the AoI or no Features match the filter criteria."
)
downloaded_metadata = downloaded_metadata.drop_duplicates(subset=["geometry"])
if sampling_threshold is not None:
downloaded_metadata = spatial_sampling(downloaded_metadata, sampling_threshold)

if randomize_order is True:
downloaded_metadata = downloaded_metadata.sample(frac=1).reset_index(drop=True)

downloaded_metadata = downloaded_metadata.drop_duplicates(subset=["geometry"])

total_images = len(downloaded_metadata)
if total_images > 100000:
raise CustomError(
Expand Down
4 changes: 4 additions & 0 deletions mapswipe_workers/mapswipe_workers/utils/spatial_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ def spatial_sampling(df, interval_length):

if interval_length:
sequence_df = filter_points(sequence_df, interval_length)
if "is_pano" in sequence_df.columns:
# below line prevents FutureWarning
# (https://stackoverflow.com/questions/73800841/add-series-as-a-new-row-into-dataframe-triggers-futurewarning)
sequence_df["is_pano"] = sequence_df["is_pano"].astype(bool)
sampled_sequence_df = pd.concat([sampled_sequence_df, sequence_df], axis=0)

# reverse order such that sequence are in direction of travel
Expand Down