Add vector tile support in completeness project #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenhelium
force-pushed
the
feature/completeness-vector-tile
branch
3 times, most recently
from
f5ee940 to
d407c4c
Compare
frozenhelium
force-pushed
the
feature/completeness-vector-tile
branch
2 times, most recently
from
95d3f41 to
9a5f9cb
Compare
frozenhelium
force-pushed
the
feature/completeness-vector-tile
branch
from
9a5f9cb to
2f58bf5
Compare
tnagorra
reviewed
Aug 4, 2025
| return (180 / Math.PI) * Math.atan(0.5 * (Math.exp(n) - Math.exp(-n))); | ||
| } | ||
|
|
||
| export interface GeoJsonProps { |
Contributor
There was a problem hiding this comment.
We can be a bit more explicit about the name here.
E.g. TileMapServiceGeoJsonProps
tnagorra
reviewed
Aug 4, 2025
| reference?: number | undefined, | ||
| } | ||
|
|
||
| export function createGeoJsonFromTasks( |
Contributor
There was a problem hiding this comment.
We can be a bit more explicit about the name here.
tnagorra
reviewed
Aug 4, 2025
Comment on lines
+65
to
+67
| const sorted = tasks.sort( | ||
| (a, b) => (a.taskId > b.taskId ? 1 : -1), | ||
| ); |
Contributor
There was a problem hiding this comment.
sorting tasks using sort() will most probably mutate the list
tnagorra
reviewed
Aug 4, 2025
| const usableHeight = window.innerHeight - 300; | ||
| const maxTileHeight = Math.floor(usableHeight / ROWS_PER_PAGE); | ||
| const tentetiveNumTiles = Math.max( |
Contributor
There was a problem hiding this comment.
Suggested change
| const tentetiveNumTiles = Math.max( | |
| const tentativeNumTiles = Math.max( |
tnagorra
reviewed
Aug 4, 2025
Contributor
tnagorra
left a comment
tnagorra
left a comment
There was a problem hiding this comment.
I have added some minor comments.
Contributor
Author
|
Closing in favor of #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.