ci(add-lint-typescript): Add CI workflow #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshathakuri
force-pushed
the
feature/add-ci
branch
from
c4b2994 to
fd02518
Compare
tnagorra
requested changes
Aug 15, 2025
barshathakuri
force-pushed
the
feature/add-ci
branch
from
fd02518 to
3725d9c
Compare
tnagorra
requested changes
Sep 10, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
101
to
115
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: yarn | ||
| cache-dependency-path: functions/yarn.lock | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Run ESLint | ||
| run: yarn lint | ||
|
|
||
| - name: Run TypeScript type check | ||
| run: yarn tsc --noEmit |
Contributor
There was a problem hiding this comment.
We aren't using yarn. We are using pnpm.
Comment on lines
+89
to
+90
| jobs: |
Contributor
There was a problem hiding this comment.
The jobs key is repeated. This will most probably not work!
| cache: yarn | ||
| cache-dependency-path: functions/yarn.lock | ||
|
|
||
| - name: Install dependencies |
Contributor
There was a problem hiding this comment.
Please add checks for build.
barshathakuri
force-pushed
the
feature/add-ci
branch
from
3725d9c to
64d35fc
Compare
Contributor
Author
|
Closing this PR in favor of a new one with the updated changes: #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.