Add different type for public project #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
+ Coverage 87.80% 87.81% +0.01%
===========================================
Files 204 205 +1
Lines 12186 12214 +28
Branches 1030 1030
===========================================
+ Hits 10700 10726 +26
- Misses 1104 1106 +2
Partials 382 382 ☔ View full report in Codecov by Sentry. |
sandeshit
requested review from
susilnem and
tnagorra
and removed request for
susilnem
susilnem
previously approved these changes
Oct 15, 2025
Comment on lines
41
to
45
| def name(self, project: strawberry.Parent[Project]) -> str: | ||
| if getattr(project, "generated_name", None): | ||
| return project.generated_name # type: ignore[reportAttributeAccessIssue] | ||
| # This is used for mutation response | ||
| return project.generate_name() |
Member
There was a problem hiding this comment.
We might just need to return the query response.
tnagorra
previously approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
printThis PR contains valid: