Skip to content

Conversation

@Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Oct 8, 2025

Depends on

Changes

  • Add test for results for validate, validate image.

PRoject Type

  • Validate
  • Validate Image
  • Street

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 98.19820% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.80%. Comparing base (47216da) to head (1a9b570).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...ct/tests/e2e_create_validate_image_project_test.py 97.14% 1 Missing and 1 partial ⚠️
.../project/tests/e2e_create_validate_project_test.py 97.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
+ Coverage    87.46%   87.80%   +0.34%     
===========================================
  Files          204      204              
  Lines        11974    12186     +212     
  Branches      1025     1030       +5     
===========================================
+ Hits         10473    10700     +227     
+ Misses        1111     1104       -7     
+ Partials       390      382       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title chore(test): add test case for result for validate, validate-image Result test case for validate, validate-image, street Oct 8, 2025
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/result-export-test branch 6 times, most recently from 8e229d7 to 2b0bf8b Compare October 10, 2025 03:15
@susilnem susilnem force-pushed the feature/result-export-test branch 2 times, most recently from a74cb57 to f84c7f0 Compare October 12, 2025 17:14
@susilnem susilnem marked this pull request as ready for review October 13, 2025 02:21
@tnagorra tnagorra force-pushed the feature/result-export-test branch from 2dd706d to 8edb205 Compare October 13, 2025 05:02
@tnagorra tnagorra force-pushed the feature/result-export-test branch from 8edb205 to 1a9b570 Compare October 13, 2025 05:03
@tnagorra tnagorra merged commit bb75256 into develop Oct 13, 2025
6 checks passed
@tnagorra tnagorra deleted the feature/result-export-test branch October 13, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants