Feature: Street project type #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susilnem
force-pushed
the
feature/street-project
branch
2 times, most recently
from
504dfda to
4375930
Compare
tnagorra
requested changes
Aug 26, 2025
susilnem
force-pushed
the
feature/street-project
branch
2 times, most recently
from
37d98f2 to
6120638
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #118 +/- ##
===========================================
- Coverage 80.39% 78.93% -1.46%
===========================================
Files 176 183 +7
Lines 8982 9390 +408
Branches 800 855 +55
===========================================
+ Hits 7221 7412 +191
- Misses 1468 1681 +213
- Partials 293 297 +4 ☔ View full report in Codecov by Sentry. |
susilnem
force-pushed
the
feature/street-project
branch
2 times, most recently
from
129acc8 to
7c69c66
Compare
susilnem
force-pushed
the
feature/street-project
branch
2 times, most recently
from
f2b8fad to
8c0742e
Compare
tnagorra
requested changes
Sep 1, 2025
Comment on lines
+1611
to
+1619
| "mapillaryImageFilters": { | ||
| "isPano": True, | ||
| "creatorId": None, | ||
| "organizationId": None, | ||
| "startTime": None, | ||
| "endTime": None, | ||
| "randomizeOrder": False, | ||
| "samplingThreshold": None, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Do we need to group these by mapillaryImageFilters? @thenav56
tnagorra
reviewed
Sep 2, 2025
tnagorra
requested changes
Sep 2, 2025
tnagorra
reviewed
Sep 3, 2025
| Field( | ||
| default=None, | ||
| pattern=r"^\d{4}-\d{2}-\d{2}$", | ||
| pattern=r"^\d{4}-(0?[1-9]|1[0-2])-(0?[1-9]|[12]\d|3[01])$", |
Collaborator
There was a problem hiding this comment.
Let's add a description.
"A valid date in yyyy-mm-dd format"
tnagorra
previously approved these changes
Sep 3, 2025
tnagorra
force-pushed
the
feature/street-project
branch
from
1835873 to
c9f8fec
Compare
- Add mapillary api call setup - create project specific type
- Add Tutorial setup for street project - Add typing for the tutorial and project objects
- Merge migrations with develop
tnagorra
force-pushed
the
feature/street-project
branch
from
c9f8fec to
a48328d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Depends on
Changes to configurations
This PR doesn't introduce any:
printThis PR contains valid: